From: Ido Schimmel <idosch@idosch.org>
To: Nikolay Aleksandrov <nikolay@nvidia.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
netdev@vger.kernel.org, Roopa Prabhu <roopa@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH] net: bridge: multicast: notify switchdev driver whenever MC processing gets disabled
Date: Tue, 15 Feb 2022 15:42:36 +0200 [thread overview]
Message-ID: <YgutzPtNjTIbovHM@shredder> (raw)
In-Reply-To: <9429cc71-1b0f-7fe3-c9dc-12246a397e96@nvidia.com>
On Tue, Feb 15, 2022 at 10:31:41AM +0200, Nikolay Aleksandrov wrote:
> (+CC Ido)
> On 15/02/2022 07:13, Jakub Kicinski wrote:
> > On Fri, 11 Feb 2022 15:14:26 +0200 Oleksandr Mazur wrote:
> >> Whenever bridge driver hits the max capacity of MDBs, it disables
> >> the MC processing (by setting corresponding bridge option), but never
> >> notifies switchdev about such change (the notifiers are called only upon
> >> explicit setting of this option, through the registered netlink interface).
> >>
> >> This could lead to situation when Software MDB processing gets disabled,
> >> but this event never gets offloaded to the underlying Hardware.
> >>
> >> Fix this by adding a notify message in such case.
> >
> > Any comments on this one?
> >
> > We have drivers offloading mdb so presumably this should have a Fixes
> > tag and go to net, right?
>
> The change looks ok, but it'd be nice to get switchdev folks comment as well.
> About the tree, -net should be targeted. I think the issue has existed
> since mdb disabled could be offloaded, so the tag should be:
>
> Fixes: 147c1e9b902c ("switchdev: bridge: Offload multicast disabled")
LGTM
Oleksandr, please mark future patches as net/net-next:
https://docs.kernel.org/networking/netdev-FAQ.html#how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in
next prev parent reply other threads:[~2022-02-15 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 13:14 [PATCH] net: bridge: multicast: notify switchdev driver whenever MC processing gets disabled Oleksandr Mazur
2022-02-15 5:13 ` Jakub Kicinski
2022-02-15 8:31 ` Nikolay Aleksandrov
2022-02-15 13:42 ` Ido Schimmel [this message]
2022-02-15 13:34 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgutzPtNjTIbovHM@shredder \
--to=idosch@idosch.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=oleksandr.mazur@plvision.eu \
--cc=roopa@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).