From: Ido Schimmel <idosch@idosch.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Petr Machata <petrm@nvidia.com>
Subject: Re: [PATCH net] net: dcb: flush lingering app table entries for unregistered devices
Date: Wed, 2 Mar 2022 17:31:36 +0200 [thread overview]
Message-ID: <Yh+N2OCM+Mv3GWoO@shredder> (raw)
In-Reply-To: <20220301163632.pcag3zgluewlwnh3@skbuf>
On Tue, Mar 01, 2022 at 04:36:32PM +0000, Vladimir Oltean wrote:
> On Tue, Mar 01, 2022 at 06:23:16PM +0200, Ido Schimmel wrote:
> > On Thu, Feb 24, 2022 at 06:01:54PM +0200, Vladimir Oltean wrote:
> > > +static void dcbnl_flush_dev(struct net_device *dev)
> > > +{
> > > + struct dcb_app_type *itr, *tmp;
> > > +
> > > + spin_lock(&dcb_lock);
> >
> > Should this be spin_lock_bh()? According to commit 52cff74eef5d ("dcbnl
> > : Disable software interrupts before taking dcb_lock") this lock can be
> > acquired from softIRQ.
>
> Could be. I didn't notice the explanation and I was even wondering in
> which circumstance would it be needed to disable softirqs...
> Now that I see the explanation I think the dcb_rpl -> cxgb4_dcb_handle_fw_update
> -> dcb_ieee_setapp call path is problematic, when a different
> DCB-enabled interface unregisters concurrently with a firmware event.
Yep. Can you please send a fix so that it gets into Jakub's PR tomorrow?
next prev parent reply other threads:[~2022-03-02 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 16:01 [PATCH net] net: dcb: flush lingering app table entries for unregistered devices Vladimir Oltean
2022-02-25 10:50 ` patchwork-bot+netdevbpf
2022-03-01 16:23 ` Ido Schimmel
2022-03-01 16:36 ` Vladimir Oltean
2022-03-02 15:31 ` Ido Schimmel [this message]
2022-03-02 19:16 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh+N2OCM+Mv3GWoO@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox