From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-rockchip@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] net: phy: fix motorcomm module automatic loading
Date: Tue, 1 Mar 2022 00:14:38 +0000 [thread overview]
Message-ID: <Yh1lboz7VDiuYuZV@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220228233057.1140817-1-pgwipeout@gmail.com>
On Mon, Feb 28, 2022 at 06:30:57PM -0500, Peter Geis wrote:
> The sentinel compatible entry whitespace causes automatic module loading
> to fail with certain userspace utilities. Fix this by removing the
> whitespace and sentinel comment, which is unnecessary.
Umm. How does it fail?
> static const struct mdio_device_id __maybe_unused motorcomm_tbl[] = {
> { PHY_ID_MATCH_EXACT(PHY_ID_YT8511) },
> - { /* sentinal */ }
> + {}
These two should be 100% identical in terms of the object code produced,
and thus should have no bearing on the ability for the module to be
loaded.
Have you investigated the differences in the produced object code?
If not, please do so, and describe what they were. Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-03-01 0:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 23:30 [PATCH v1] net: phy: fix motorcomm module automatic loading Peter Geis
2022-03-01 0:14 ` Russell King (Oracle) [this message]
2022-03-01 0:44 ` Peter Geis
2022-04-29 12:51 ` Peter Geis
2022-04-30 15:52 ` Andrew Lunn
2022-04-30 16:31 ` Peter Geis
2022-04-30 16:48 ` Andrew Lunn
2022-04-30 20:19 ` Heiner Kallweit
2022-05-01 6:22 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh1lboz7VDiuYuZV@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).