From: Tony Lu <tonylu@linux.alibaba.com>
To: Dust Li <dust.li@linux.alibaba.com>
Cc: Karsten Graul <kgraul@linux.ibm.com>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next] net/smc: fix compile warning for smc_sysctl
Date: Wed, 2 Mar 2022 13:49:08 +0800 [thread overview]
Message-ID: <Yh8FVOQZ+nPN50D+@TonyMac-Alibaba> (raw)
In-Reply-To: <20220302034312.31168-1-dust.li@linux.alibaba.com>
On Wed, Mar 02, 2022 at 11:43:12AM +0800, Dust Li wrote:
> Fix build:
>
> In file included from net/smc/smc_sysctl.c:17:
> >> net/smc/smc_sysctl.h:23:5: warning: no previous prototype \
> for function 'smc_sysctl_init' [-Wmissing-prototypes]
> int smc_sysctl_init(void)
> ^
>
> and
>
> >> WARNING: modpost: vmlinux.o(.text+0x12ced2d): Section mismatch \
> in reference from the function smc_sysctl_exit() to the variable
> .init.data:smc_sysctl_ops
> The function smc_sysctl_exit() references
> the variable __initdata smc_sysctl_ops.
> This is often because smc_sysctl_exit lacks a __initdata
> annotation or the annotation of smc_sysctl_ops is wrong.
>
> Fixes: 462791bbfa35 ("net/smc: add sysctl interface for SMC")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
Thanks for the fixing.
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
next prev parent reply other threads:[~2022-03-02 5:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 3:43 [PATCH net-next] net/smc: fix compile warning for smc_sysctl Dust Li
2022-03-02 5:49 ` Tony Lu [this message]
2022-03-02 15:02 ` kernel test robot
2022-03-02 19:45 ` Jakub Kicinski
2022-03-03 2:35 ` dust.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh8FVOQZ+nPN50D+@TonyMac-Alibaba \
--to=tonylu@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).