From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, netdev <netdev@vger.kernel.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Eric Dumazet <edumazet@google.com>,
Chris Wilson <chris.p.wilson@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [Intel-gfx] [PATCH v3 08/11] drm/i915: Separate wakeref tracking
Date: Tue, 22 Feb 2022 11:44:37 +0200 [thread overview]
Message-ID: <YhSwhdr96qnka4yx@intel.com> (raw)
In-Reply-To: <acc45712-b6c7-5cc8-920f-93f3db45413f@intel.com>
On Tue, Feb 22, 2022 at 10:28:33AM +0100, Andrzej Hajda wrote:
>
>
> On 22.02.2022 08:12, Ville Syrjälä wrote:
> > On Tue, Feb 22, 2022 at 12:25:39AM +0100, Andrzej Hajda wrote:
> >> -static noinline depot_stack_handle_t
> >> +static intel_wakeref_t
> >> track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
> >> {
> >> - depot_stack_handle_t stack, *stacks;
> >> - unsigned long flags;
> >> -
> >> - if (rpm->no_wakeref_tracking)
> >> - return -1;
> >> -
> >> - stack = __save_depot_stack();
> >> - if (!stack)
> >> + if (!rpm->available)
> >> return -1;
> > Still not the same.
> >
>
> It was fixed but in wrong place - patch 11. I will move the change here.
Doesn't look correct there either.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-02-22 9:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 23:25 [PATCH v3 00/11] drm/i915: use ref_tracker library for tracking wakerefs Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 01/11] [DO NOT MERGE] ref_tracker: implement use-after-free detection Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 02/11] [DO NOT MERGE] ref_tracker: add a count of untracked references Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 03/11] [DO NOT MERGE] ref_tracker: remove filter_irq_stacks() call Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 04/11] lib/ref_tracker: add unlocked leak print helper Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 05/11] lib/ref_tracker: __ref_tracker_dir_print improve printing Andrzej Hajda
2022-02-22 0:08 ` Eric Dumazet
2022-02-22 10:27 ` Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 06/11] lib/ref_tracker: add printing to memory buffer Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 07/11] lib/ref_tracker: remove warnings in case of allocation failure Andrzej Hajda
2022-02-21 23:54 ` Eric Dumazet
2022-02-22 10:44 ` Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 08/11] drm/i915: Separate wakeref tracking Andrzej Hajda
2022-02-22 7:12 ` [Intel-gfx] " Ville Syrjälä
2022-02-22 9:28 ` Andrzej Hajda
2022-02-22 9:44 ` Ville Syrjälä [this message]
2022-02-21 23:25 ` [PATCH v3 09/11] drm/i915: Track leaked gt->wakerefs Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 10/11] drm/i915: Correct type of wakeref variable Andrzej Hajda
2022-02-21 23:25 ` [PATCH v3 11/11] drm/i915: replace Intel internal tracker with kernel core ref_tracker Andrzej Hajda
2023-01-06 14:15 ` [Intel-gfx] " Das, Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhSwhdr96qnka4yx@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=chris.p.wilson@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).