From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 016CEC4332F for ; Wed, 23 Feb 2022 11:23:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239824AbiBWLYG (ORCPT ); Wed, 23 Feb 2022 06:24:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234705AbiBWLYF (ORCPT ); Wed, 23 Feb 2022 06:24:05 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BCDE8AE55; Wed, 23 Feb 2022 03:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645615418; x=1677151418; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=FWh5Gytqdi+aFrZmALBpSFgdHMcuZf1UxHQVAqFhB5s=; b=Lfd/d5VFioq8U76Z6qj/v1k5QV/dLpXva1E7xYTPBUEOhjljVCAdKtU9 rug7bkovoW5kFYvhrGaV8P352YAjlvcMndxqY3VMr2lH+7M6e/3FVnMCV wZF/biA+fdrZW2K4l4fKYsUln/EHReoBoODToZ6Ach85JCDRTiRra8R2k 9YbF+4DuXp/B+GbMVFmy+/sbLO2NgHlKoi6QOcrtTf86VlB0jkUNexFXd UE4W+nNx+HZWVn1rN91SPV6V0BWF5TcsGibInGGHCfhv+4jPUN+QAucom nab+qoJRG+g2njtIYLon/Tl1ApU/awm1p6SjZgwu/aTBIKEZfc7pjMVOR A==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="231915372" X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="231915372" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 03:23:37 -0800 X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="532642764" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 03:23:33 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nMpjF-007OHE-SU; Wed, 23 Feb 2022 13:22:41 +0200 Date: Wed, 23 Feb 2022 13:22:41 +0200 From: Andy Shevchenko To: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Hans de Goede Cc: Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Wolfram Sang , Peter Rosin , Russell King , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org, netdev@vger.kernel.org, Thomas Petazzoni , Alexandre Belloni Subject: Re: [RFC 10/10] net: sfp: add support for fwnode Message-ID: References: <20220221162652.103834-1-clement.leger@bootlin.com> <20220221162652.103834-11-clement.leger@bootlin.com> <20220222142513.026ad98c@fixe.home> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220222142513.026ad98c@fixe.home> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 22, 2022 at 02:25:13PM +0100, Clément Léger wrote: > Le Mon, 21 Feb 2022 19:57:39 +0200, > Andy Shevchenko a écrit : > > > On Mon, Feb 21, 2022 at 05:26:52PM +0100, Clément Léger wrote: > > > Add support to retrieve a i2c bus in sfp with a fwnode. This support > > > is using the fwnode API which also works with device-tree and ACPI. > > > For this purpose, the device-tree and ACPI code handling the i2c > > > adapter retrieval was factorized with the new code. This also allows > > > i2c devices using a software_node description to be used by sfp code. > > > > If I'm not mistaken this patch can even go separately right now, since all used > > APIs are already available. > > This patches uses fwnode_find_i2c_adapter_by_node() which is introduced > by "i2c: fwnode: add fwnode_find_i2c_adapter_by_node()" but they can > probably be contributed both in a separate series. I summon Hans into the discussion since I remember he recently refactored a bit I2C (ACPI/fwnode) APIs. Also he might have an idea about entire big picture approach with this series based on his ACPI experience. -- With Best Regards, Andy Shevchenko