From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05548C4332F for ; Fri, 25 Feb 2022 07:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238282AbiBYHwn (ORCPT ); Fri, 25 Feb 2022 02:52:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238279AbiBYHwm (ORCPT ); Fri, 25 Feb 2022 02:52:42 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB60F4BBAC for ; Thu, 24 Feb 2022 23:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yoX1eoFXR6koQBiw+7bPyW6Wds1G5QswMrdNXzAJPp4=; b=nVOUxOFRd7iyICOushjCLFg08M XVaLcz+M3dzPBhTvo3NOeAO9nqxFRvDNl2Dh2N0eGfSsxAerp24mdVmYcQoPM2fpmAv+Xaov2tuyb zD2Be6oWWNrXftsprGqgtQTPZK8NDQsyG6AaRs3nEWVyoU754gIa9rmyTdDB+QwsbxCg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nNVOV-0086Gi-CM; Fri, 25 Feb 2022 08:52:03 +0100 Date: Fri, 25 Feb 2022 08:52:03 +0100 From: Andrew Lunn To: Dimitris Michailidis Cc: davem@davemloft.net, Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH net-next v7 4/8] net/funeth: ethtool operations Message-ID: References: <20220218234536.9810-1-dmichail@fungible.com> <20220218234536.9810-5-dmichail@fungible.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 24, 2022 at 04:57:36PM -0800, Dimitris Michailidis wrote: > On Thu, Feb 24, 2022 at 12:30 PM Andrew Lunn wrote: > > > > > +static void fun_link_modes_to_ethtool(u64 modes, > > > + unsigned long *ethtool_modes_map) > > > +{ > > > +#define ADD_LINK_MODE(mode) \ > > > + __set_bit(ETHTOOL_LINK_MODE_ ## mode ## _BIT, ethtool_modes_map) > > > + > > > + if (modes & FUN_PORT_CAP_AUTONEG) > > > + ADD_LINK_MODE(Autoneg); > > > + if (modes & FUN_PORT_CAP_1000_X) > > > + ADD_LINK_MODE(1000baseX_Full); > > > + if (modes & FUN_PORT_CAP_10G_R) { > > > + ADD_LINK_MODE(10000baseCR_Full); > > > + ADD_LINK_MODE(10000baseSR_Full); > > > + ADD_LINK_MODE(10000baseLR_Full); > > > + ADD_LINK_MODE(10000baseER_Full); > > > + } > > > > > +static unsigned int fun_port_type(unsigned int xcvr) > > > +{ > > > + if (!xcvr) > > > + return PORT_NONE; > > > + > > > + switch (xcvr & 7) { > > > + case FUN_XCVR_BASET: > > > + return PORT_TP; > > > > You support twisted pair, so should you also have the BaseT_FULL link > > modes above? > > I agree with that but FW currently doesn't report BASE-T speeds in its > port capabilities and the link modes are based on them. Looks simple to fix > but needs future FW. Maybe you should drop PORT_TP until you do have the firmware fixed? > > > +static int fun_set_pauseparam(struct net_device *netdev, > > > + struct ethtool_pauseparam *pause) > > > +{ > > > + struct funeth_priv *fp = netdev_priv(netdev); > > > + u64 new_advert; > > > + > > > + if (fp->port_caps & FUN_PORT_CAP_VPORT) > > > + return -EOPNOTSUPP; > > > + /* Forcing PAUSE settings with AN enabled is unsupported. */ > > > + if (!pause->autoneg && (fp->advertising & FUN_PORT_CAP_AUTONEG)) > > > + return -EOPNOTSUPP; > > > > This seems wrong. You don't advertise you cannot advertise. You simply > > don't advertise. It could just be you have a bad variable name here? > > advertising & FUN_PORT_CAP_AUTONEG means that AN is enabled, and > when this bit is off AN is disabled. So, i was correct, the name of the variable is not so good. Maybe fp->advertising need splitting into two, fp->cap_enabled for capabilities of the firmware that are enabled, and fp->advertising for what is actually been advertised to the link partner? Andrew