From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DDDC433EF for ; Fri, 25 Feb 2022 12:08:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232284AbiBYMIk (ORCPT ); Fri, 25 Feb 2022 07:08:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbiBYMIk (ORCPT ); Fri, 25 Feb 2022 07:08:40 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0875CD04B4 for ; Fri, 25 Feb 2022 04:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wL3fwulFKu7Q36Fe0Acepx8AHZqe5Sog+xFeJ1u19Dk=; b=f1Fd1UqjLg8GKx2HvbfTtAWaO4 EDf9UtlEqm94yRac1BMwFQQ0FmmgSTyCuLNZhAV6LbpyNJiD7u82lJ0KNFUVa0U0icoJNw62CdOfK 9/UqmbLVHvvVsxvSXuLXc/U49nnXboQZFPrhC9nHz4KtJBGtw6ukhqKgRgRCpZqH3GE7o5YBc2xrL VUKZdTL2dGvcVA+tVORUXr7QvOgEgiXDVy9vZAJ167CNA9PwLPB/TOM9UEnDzpnzVp/KmLlq1WSY3 i0fHGgCB3bB4Ldhvusp1x08u/OoEorktsdzrmDdxUcW6k2mQdE3gQTupGaaKlGIgBGAEmeSPT5wGs 6CDHssSA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57484) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nNZOF-0005Kk-86; Fri, 25 Feb 2022 12:08:03 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nNZOE-00032M-4z; Fri, 25 Feb 2022 12:08:02 +0000 Date: Fri, 25 Feb 2022 12:08:02 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean , Marek Beh__n , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/6] net: dsa: sja1105: populate supported_interfaces Message-ID: References: <20220225115858.6hwi4e55fjkgqzs5@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220225115858.6hwi4e55fjkgqzs5@skbuf> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 25, 2022 at 01:58:58PM +0200, Vladimir Oltean wrote: > On Fri, Feb 25, 2022 at 11:56:02AM +0000, Russell King (Oracle) wrote: > > Populate the supported interfaces bitmap for the SJA1105 DSA switch. > > > > This switch only supports a static model of configuration, so we > > restrict the interface modes to the configured setting. > > > > Reviewed-by: Vladimir Oltean Signed-off-by: Russell King (Oracle) > > These all appear on the same line, can you please fix and resend? I hate vi/vim precisely because of this. How this problem happens. I read the email in mutt under KDE's kconsole with your attributation. I select the attributation so it can be pasted. I edit the commit, which starts vi, move to the line containing my sign-off, hit 'i' and paste it in. The result is a line that _looks_ in vi as being entirely correct. The next line follows on as if it is a separate line. I save the commit message. When I look at it in "git log", again, everything looks good. The only times that it can be identified is after sending and looking at it in mutt, and noticing that the Signed-off-by line appears to have a# '+' prefix, indicating that mutt wrapped the line - or after it gets merged into net-next when linux-next identifies the lack of s-o-b, by which time it's too late to fix. How do others avoid this problem? Not use vi/vim, but use some other editor such as emacs or microemacs that doesn't have this crazy way of dealing with multiple lines? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!