From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "Marek Behún" <kabel@kernel.org>,
UNGLinuxDriver@microchip.com, "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] net: dsa: ocelot: populate supported_interfaces
Date: Fri, 25 Feb 2022 16:14:20 +0000 [thread overview]
Message-ID: <YhkAXKh0WIQmMYol@shell.armlinux.org.uk> (raw)
In-Reply-To: <E1nNd76-00Anzt-IH@rmk-PC.armlinux.org.uk>
On Fri, Feb 25, 2022 at 04:06:36PM +0000, Russell King (Oracle) wrote:
> Populate the supported interfaces bitmap for the Ocelot DSA switches.
>
> Since all sub-drivers only support a single interface mode, defined by
> ocelot_port->phy_mode, we can handle this in the main driver code
> without reference to the sub-driver.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/dsa/ocelot/felix.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
> index 9959407fede8..88fbbd03c81b 100644
> --- a/drivers/net/dsa/ocelot/felix.c
> +++ b/drivers/net/dsa/ocelot/felix.c
> @@ -778,6 +778,15 @@ static int felix_vlan_del(struct dsa_switch *ds, int port,
> return ocelot_vlan_del(ocelot, port, vlan->vid);
> }
>
> +static void felix_phylink_get_caps(struct dsa_switch *ds, int port,
> + struct phylink_config *config)
> +{
> + struct ocelot *ocelot = ds->priv;
> +
> + __set_bit(ocelot->ports[port].phy_mode,
Sorry, this should be ->phy_mode.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-02-25 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 16:05 [PATCH net-next 0/4] net: dsa: ocelot: phylink updates Russell King (Oracle)
2022-02-25 16:06 ` [PATCH net-next 1/4] net: dsa: ocelot: populate supported_interfaces Russell King (Oracle)
2022-02-25 16:14 ` Russell King (Oracle) [this message]
2022-02-25 16:06 ` [PATCH net-next 2/4] net: dsa: ocelot: remove interface checks Russell King (Oracle)
2022-02-25 16:06 ` [PATCH net-next 3/4] net: dsa: ocelot: convert to mac_select_pcs() Russell King (Oracle)
2022-02-25 16:06 ` [PATCH net-next 4/4] net: dsa: ocelot: mark as non-legacy Russell King (Oracle)
-- strict thread matches above, loose matches on Subject: below --
2022-02-25 16:19 [PATCH net-next v2 0/4] net: dsa: ocelot: phylink updates Russell King (Oracle)
2022-02-25 16:19 ` [PATCH net-next 1/4] net: dsa: ocelot: populate supported_interfaces Russell King (Oracle)
2022-02-25 16:25 ` Vladimir Oltean
2022-02-25 16:31 ` Russell King (Oracle)
2022-02-25 17:16 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhkAXKh0WIQmMYol@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).