From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8086FC433EF for ; Fri, 25 Feb 2022 16:32:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243014AbiBYQcg (ORCPT ); Fri, 25 Feb 2022 11:32:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243012AbiBYQcf (ORCPT ); Fri, 25 Feb 2022 11:32:35 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FA581D86E7 for ; Fri, 25 Feb 2022 08:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1t5cwZvxhesj2xl5ihjJctiwbkRyj1zv5ihyBV2Dq2s=; b=O61lRetCwWe/539bjv7pC/SElo tfiCPU5bdODVh6IgBy3Z7mmCZW1AgJFz+38QTE6FAz5UqidakeAaEq9/S6vsI5AgjHLgHpCBQfDSc fyKeb+97WQjbWRaVU5SSGWKFJ/PaVFfHJH5n+AM3RgrtmlWTK1ozmOzunuKo5LnoO5pUNBTw/P4MK oizaGlB8sO/bA9uN5efek5B3OpyT0akFM1fGHrwbI8z7MpvzYikTBapu2WI6VzJckB6cIJygEAobJ 8NrX2NkRP0vbP6xm6Dp1AqV1XWHnU27Y0gx8DyF49eF+6voSsk+gBh0gpctrGETJU04ZLkW5mKufL 1R8doc9g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57504) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nNdVZ-0005j6-OR; Fri, 25 Feb 2022 16:31:53 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nNdVY-0003EB-B9; Fri, 25 Feb 2022 16:31:52 +0000 Date: Fri, 25 Feb 2022 16:31:52 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Alexandre Belloni , Claudiu Manoil , Marek =?utf-8?B?QmVoxILImW4=?= , "UNGLinuxDriver@microchip.com" , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 1/4] net: dsa: ocelot: populate supported_interfaces Message-ID: References: <20220225162530.cnt4da7zpo6gxl4z@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220225162530.cnt4da7zpo6gxl4z@skbuf> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 25, 2022 at 04:25:30PM +0000, Vladimir Oltean wrote: > On Fri, Feb 25, 2022 at 04:19:25PM +0000, Russell King (Oracle) wrote: > > Populate the supported interfaces bitmap for the Ocelot DSA switches. > > > > Since all sub-drivers only support a single interface mode, defined by > > ocelot_port->phy_mode, we can handle this in the main driver code > > without reference to the sub-driver. > > > > Signed-off-by: Russell King (Oracle) > > --- > > Reviewed-by: Vladimir Oltean > Tested-by: Vladimir Oltean Brilliant, thanks. This is the final driver in net-next that was making use of phylink_set_pcs(), so once this series is merged, that function will only be used by phylink internally. The next patch I have in the queue is to remove that function. Marek Behún will be very happy to see phylink_set_pcs() gone. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!