From: Hangbin Liu <liuhangbin@gmail.com>
To: David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCHv2 iproute2-next] bond: add ns_ip6_target option
Date: Mon, 28 Feb 2022 11:43:21 +0800 [thread overview]
Message-ID: <YhxE2fwJWHkNzR90@Laptop-X1> (raw)
In-Reply-To: <243fb2a1-f8d5-c427-a0a7-44ac3d71af58@kernel.org>
On Sun, Feb 27, 2022 at 06:32:41PM -0700, David Ahern wrote:
> On 2/20/22 10:54 PM, Hangbin Liu wrote:
> > Similar with arp_ip_target, this option add bond IPv6 NS/NA monitor
> > support. When IPv6 target was set, the ARP target will be disabled.
> >
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> > ---
> > v2: define BOND_MAX_NS_TARGETS
> > ---
> > ip/iplink_bond.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 52 insertions(+), 1 deletion(-)
> >
>
> > + } else if (matches(*argv, "ns_ip6_target") == 0) {
>
> changed matches to strcmp and applied.
>
> we are not accepting any more uses of matches.
Oh, my bad. I forgot to change match to strcmp when copy/paste the
arp_ip_target code...
Hangbin
next prev parent reply other threads:[~2022-02-28 3:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 5:54 [PATCHv2 net-next 0/5] bonding: add IPv6 NS/NA monitor support Hangbin Liu
2022-02-21 5:54 ` [PATCHv2 net-next 1/5] ipv6: separate ndisc_ns_create() from ndisc_send_ns() Hangbin Liu
2022-02-21 5:54 ` [PATCHv2 net-next 2/5] Bonding: split bond_handle_vlan from bond_arp_send Hangbin Liu
2022-02-21 5:54 ` [PATCHv2 net-next 3/5] bonding: add extra field for bond_opt_value Hangbin Liu
2022-02-21 5:54 ` [PATCHv2 net-next 4/5] bonding: add new parameter ns_targets Hangbin Liu
2022-02-21 5:54 ` [PATCHv2 net-next 5/5] bonding: add new option ns_ip6_target Hangbin Liu
2022-02-21 5:54 ` [PATCHv2 iproute2-next] bond: add ns_ip6_target option Hangbin Liu
2022-02-28 1:32 ` David Ahern
2022-02-28 3:43 ` Hangbin Liu [this message]
2022-02-21 12:20 ` [PATCHv2 net-next 0/5] bonding: add IPv6 NS/NA monitor support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhxE2fwJWHkNzR90@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox