Re: [PATCH net-next 2/3] net: mdio: mscc-miim: replace magic numbers for the bus reset

Andrew Lunn
2022-03-13T00:52:09Z

> diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c
> index 64fb76c1e395..7773d5019e66 100644
> --- a/drivers/net/mdio/mdio-mscc-miim.c
> +++ b/drivers/net/mdio/mdio-mscc-miim.c
> @@ -158,18 +158,18 @@ static int mscc_miim_reset(struct mii_bus *bus)
> {
> struct mscc_miim_dev *miim = bus->priv;
> int offset = miim->phy_reset_offset;
> + int mask = PHY_CFG_PHY_ENA | PHY_CFG_PHY_COMMON_RESET |
> + PHY_CFG_PHY_RESET;

> - ret = regmap_write(miim->phy_regs,
> - MSCC_PHY_REG_PHY_CFG + offset, 0x1ff);
> + ret = regmap_write(miim->phy_regs, offset, mask);

Is mask the correct name? It is not being used in the typical way for
a mask.

Andrew