From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B24C433EF for ; Mon, 14 Mar 2022 11:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238890AbiCNL0t (ORCPT ); Mon, 14 Mar 2022 07:26:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbiCNL0s (ORCPT ); Mon, 14 Mar 2022 07:26:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2C8939687; Mon, 14 Mar 2022 04:25:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8FA15B80D91; Mon, 14 Mar 2022 11:25:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8A34C340E9; Mon, 14 Mar 2022 11:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647257136; bh=rZOWKbjELHYqrIoGaZbW7LvgfxBv3MLhfimZpgWM0d4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rFkpLC85NWCpMMC/+yqgSEev4fW1GgxKieVXe3BX95EkuvPTZFaxLYZo57axNilkO SX6e6Gf+hOOR0R2zdyy/Rb8AHbT1htZXyp0jOSFJvt4p5ru4Bdqmv331dThy3TMvCd /oOVVLaU2ppeSXLYJd3k3xTKofNZ7r1GqUURKvhg= Date: Mon, 14 Mar 2022 12:25:31 +0100 From: "gregkh@linuxfoundation.org" To: Vladimir Oltean Cc: Daniel Suchy , "davem@davemloft.net" , "rafael.richter@gin.de" , "netdev@vger.kernel.org" , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: patch problem - mv88e6xxx: flush switchdev FDB workqueue Message-ID: References: <20220313141030.ztwhuhfwxjfzi5nb@skbuf> <20220314111750.ym5xiuvusj4kl4t4@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220314111750.ym5xiuvusj4kl4t4@skbuf> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 14, 2022 at 11:17:50AM +0000, Vladimir Oltean wrote: > On Mon, Mar 14, 2022 at 08:21:30AM +0100, gregkh@linuxfoundation.org wrote: > > On Mon, Mar 14, 2022 at 07:38:50AM +0100, gregkh@linuxfoundation.org wrote: > > > On Sun, Mar 13, 2022 at 02:10:31PM +0000, Vladimir Oltean wrote: > > > > Hi Daniel, > > > > > > > > On Sun, Mar 13, 2022 at 03:03:07PM +0100, Daniel Suchy wrote: > > > > > Hello, > > > > > > > > > > I noticed boot problems on my Turris Omnia (with Marvell 88E6176 switch > > > > > chip) after "net: dsa: mv88e6xxx: flush switchdev FDB workqueue before > > > > > removing VLAN" commit https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2566a89b9e163b2fcd104d6005e0149f197b8a48 > > > > > > > > > > Within logs I catched hung kernel tasks (see below), at least first is > > > > > related to DSA subsystem. > > > > > > > > > > When I revert this patch, everything works as expected and without any > > > > > issues. > > > > > > > > > > In my setup, I have few vlans on affected switch (i'm using ifupdown2 v3.0 > > > > > with iproute2 5.16 for configuration). > > > > > > > > > > It seems your this patch introduces some new problem (at least for 5.15 > > > > > kernels). I suggest revert this patch. > > > > > > > > > > - Daniel > > > > > > > > Oh wow, I'm terribly sorry. Yes, this patch shouldn't have been > > > > backported to kernel 5.15 and below, but I guess I missed the > > > > backport notification email and forgot to tell Greg about this. > > > > Patch "net: dsa: mv88e6xxx: flush switchdev FDB workqueue before > > > > removing VLAN" needs to be immediately reverted from these trees. > > > > > > > > Greg, to avoid this from happening in the future, would something like > > > > this work? Is this parsed in some way? > > > > > > > > Depends-on: 0faf890fc519 ("net: dsa: drop rtnl_lock from dsa_slave_switchdev_event_work") # which first appeared in v5.16 > > > > > > The "Fixes:" tag will solve this, please just use that in the future. > > > > Ah, you did have a fixes tag here, so then use the way to say "you also > > need to add another patch here" by adding the sha to the line for the > > stable tree: > > cc: stable@vger.kernel.org # 0faf890fc519 > > > > So, should I just backport that commit instead? The "Fixes:" line says > > this needs to be backported to 4.14, which is why I added it to these > > trees. > > > > thanks, > > No, don't backport the dependency, just revert the patch (hence my > question: how can I describe "don't backport beyond commit X"?). > > Here, you can apply the revert attached. Thanks, now queued up. greg k-h