From: Andrew Lunn <andrew@lunn.ch>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v2] net: dsa: qca8k: pack driver struct and improve cache use
Date: Thu, 3 Mar 2022 03:25:09 +0100 [thread overview]
Message-ID: <YiAnBbECC4ANIwCf@lunn.ch> (raw)
In-Reply-To: <20220303015327.k3fqkkxunm6kihjl@skbuf>
On Thu, Mar 03, 2022 at 03:53:27AM +0200, Vladimir Oltean wrote:
> On Mon, Feb 28, 2022 at 12:04:08PM +0100, Ansuel Smith wrote:
> > Pack qca8k priv and other struct using pahole and set the first priv
> > struct entry to mgmt_master and mgmt_eth_data to speedup access.
> > While at it also rework pcs struct and move it qca8k_ports_config
> > following other configuration set for the cpu ports.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
>
> How did you "pack" struct qca8k_priv exactly?
As far as i can see, nothing in qca8k_priv is on the hot path. So i
doubt anything changed here will make a difference. The MDIO bus is
the bottleneck, not the memory interface.
Andrew
next prev parent reply other threads:[~2022-03-03 2:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 11:04 [net-next PATCH v2] net: dsa: qca8k: pack driver struct and improve cache use Ansuel Smith
2022-03-03 1:53 ` Vladimir Oltean
2022-03-03 2:25 ` Andrew Lunn [this message]
2022-03-21 16:07 ` Ansuel Smith
2022-03-21 17:22 ` Vladimir Oltean
2022-03-21 17:26 ` Ansuel Smith
2022-03-21 17:31 ` Ansuel Smith
2022-03-21 18:22 ` Vladimir Oltean
2022-03-21 18:06 ` Ansuel Smith
2022-03-21 18:55 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiAnBbECC4ANIwCf@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).