From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B97AFC433F5 for ; Fri, 4 Mar 2022 07:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233879AbiCDHDe (ORCPT ); Fri, 4 Mar 2022 02:03:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232656AbiCDHDc (ORCPT ); Fri, 4 Mar 2022 02:03:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7933820F53 for ; Thu, 3 Mar 2022 23:02:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5ADC461D55 for ; Fri, 4 Mar 2022 07:02:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F302C340E9; Fri, 4 Mar 2022 07:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646377362; bh=L8kaEBCCbaB2RO3ZzJG3ELbwC8QItZ6kqT+c9BvjG5k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ugzMbDCwoI3pejV+tCgGD0unIjZU/2FRA+I3XTyYQmf9x6Or5C09Kg/t1e18RL3h8 rq89Lvp/K7TLmqKQUzC+lLjzc9dnPUWfhbadub+NsmlvzZkhmAk72YqfE9pKnfruqT y/IjB/vTZ6ILuQj2N1cv3zr+oqUZT3iWSz1YYQu8ZgPg++iUYnOAao095atLRye5GU 4QrlJ+mXceW7MheMWENRH83trh7UBAjSN5cqQ6BhgE8UQo5NYrNAndHeA/bmIFhuM0 Ahe9XdsKg86YxJFNS4RFlkJ6zua3bGnWZ0xYGA6LvcDBFC37wT3TMjjzn0Uno+Qxre CwyAkwyi6EfgA== Date: Fri, 4 Mar 2022 09:02:37 +0200 From: Leon Romanovsky To: Shangyan Zhou Cc: netdev@vger.kernel.org Subject: Re: [PATCH v2] rdma: Fix res_print_uint() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 04, 2022 at 11:00:28AM +0800, Shangyan Zhou wrote: > Print unsigned int64 should use print_color_u64() and fmt string should be "%" PRIu64. > > Signed-off-by: Shangyan Zhou > --- > rdma/res.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rdma/res.c b/rdma/res.c > index 21fef9bd..1af61aa6 100644 > --- a/rdma/res.c > +++ b/rdma/res.c > @@ -214,7 +214,7 @@ void res_print_uint(struct rd *rd, const char *name, uint64_t val, > if (!nlattr) > return; > print_color_uint(PRINT_ANY, COLOR_NONE, name, name, val); > - print_color_uint(PRINT_FP, COLOR_NONE, NULL, " %d ", val); > + print_color_u64(PRINT_FP, COLOR_NONE, NULL, " %" PRIu64 " ", val); > } Except the res_print_uint() that should be changed too, the patch LGTM. Thanks, Reviewed-by: Leon Romanovsky