From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E1FC433EF for ; Fri, 4 Mar 2022 16:56:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240853AbiCDQ5h (ORCPT ); Fri, 4 Mar 2022 11:57:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240663AbiCDQ5g (ORCPT ); Fri, 4 Mar 2022 11:57:36 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6FB11C4B1D for ; Fri, 4 Mar 2022 08:56:48 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id n33-20020a05600c3ba100b003832caf7f3aso4286138wms.0 for ; Fri, 04 Mar 2022 08:56:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=OeG+ww/Pdl38zR6EndtrKnHOChw4NiKGrdOcb/INWpM=; b=UMOLRWI2FdlLVH6TCzeS4kpeBRdBi4juFCEroIm0oaa9CA6iyntAXKeauE+Ee6zFzp nR0XKPembJQcTFnlmU/ZEldn9+lU1O7YMLhV/S8e2JS0asxXKMOOoZ5DgugFAd9kw2S4 RH+KAn8eayIRlvE31Y2XkjVCYMh/WJ4lHnAu5Ayb62Bur6cdhPtUbiLILVb44SzWPDOa 2z2yIYRGlAc4lFtAc/bsdIfm3TN/EGUNGqqj+oegKaIjfnn0ntYyfiHPzy0lzHPRs1cA OPcdNm7C/IkHPbZA/XLaXlIwT+BWEKkSUCwIrcfrHsYUdJXqJPgTELJYugjTCstr94VH BzvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=OeG+ww/Pdl38zR6EndtrKnHOChw4NiKGrdOcb/INWpM=; b=zJHQnFFvQOYPXY85wX3c5fr6aVzpVqALq6+xXsFYb61UzAIUggEggxEWJrdU8QFgWE 9u52ucV1EIKrDPLXzZ7jbOn1OLXF9wezbyENKLDtcdypJyteSJCYtLnpZbdNJPO9+NPg 2yI3bq0i4HolCMXlq2xSvDLouf4RpDKfGppSTUW/VFp5sbdZLcOf0w7ZsE+3FTWhqZKq SJ02qFEBNLAPXD0AO1xvDj+n5Rs8JIQWW1E+ERiNu9K/V2qBJ8d9z6nk7HWOhR4UqLXn M9nXwzM1hoTFxXc1HxoEpH/IYrvzllS+xJ/TJQB3NMdML35ZcS1ZVHHG8lUqz4sB9pgF Y+Gw== X-Gm-Message-State: AOAM531Z9OU57mH96rpfsVgv/9MGMmT6OFxgWmcc2XztaaXkTwoeTuBe D9oAXygEWR0JmqoyMLnu+C0LFS+RGR6BPQ== X-Google-Smtp-Source: ABdhPJyMtgycuIr7vOgYL0Dp0iSnVrXZOJULcr8VvGwrH6xblkcMJwOAVAoqNil1zst8+h6cfCcjWw== X-Received: by 2002:a1c:e916:0:b0:37c:f44f:573 with SMTP id q22-20020a1ce916000000b0037cf44f0573mr8795252wmc.179.1646413007235; Fri, 04 Mar 2022 08:56:47 -0800 (PST) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id p3-20020a05600c358300b003897e440047sm2501809wmq.28.2022.03.04.08.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 08:56:46 -0800 (PST) Date: Fri, 4 Mar 2022 16:56:44 +0000 From: Lee Jones To: "Michael S. Tsirkin" Cc: jasowang@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, stable@vger.kernel.org, syzbot+adc3cb32385586bec859@syzkaller.appspotmail.com Subject: Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use Message-ID: References: <20220302075421.2131221-1-lee.jones@linaro.org> <20220304114718-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220304114718-mutt-send-email-mst@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 04 Mar 2022, Michael S. Tsirkin wrote: > On Wed, Mar 02, 2022 at 07:54:21AM +0000, Lee Jones wrote: > > vhost_vsock_handle_tx_kick() already holds the mutex during its call > > to vhost_get_vq_desc(). All we have to do is take the same lock > > during virtqueue clean-up and we mitigate the reported issues. > > > > Link: https://syzkaller.appspot.com/bug?extid=279432d30d825e63ba00 > > > > Cc: > > Reported-by: syzbot+adc3cb32385586bec859@syzkaller.appspotmail.com > > Signed-off-by: Lee Jones > > OK so please post series with this and the warning > cleaned up comments and commit logs explaining that > this is just to make debugging easier in case > we have issues in the future, it's not a bugfix. No problem. Just to clarify, drop Cc: Stable also? -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog