From: Leon Romanovsky <leon@kernel.org>
To: Dust Li <dust.li@linux.alibaba.com>
Cc: Karsten Graul <kgraul@linux.ibm.com>,
davem@davemloft.net, kuba@kernel.org,
Guangguan Wang <guangguan.wang@linux.alibaba.com>,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next] Revert "net/smc: don't req_notify until all CQEs drained"
Date: Fri, 4 Mar 2022 19:12:44 +0200 [thread overview]
Message-ID: <YiJIjNu/OO1o11Vc@unreal> (raw)
In-Reply-To: <20220304091719.48340-1-dust.li@linux.alibaba.com>
On Fri, Mar 04, 2022 at 05:17:19PM +0800, Dust Li wrote:
> This reverts commit a505cce6f7cfaf2aa2385aab7286063c96444526.
>
> Leon says:
> We already discussed that. SMC should be changed to use
> RDMA CQ pool API
> drivers/infiniband/core/cq.c.
> ib_poll_handler() has much better implementation (tracing,
> IRQ rescheduling, proper error handling) than this SMC variant.
>
> Since we will switch to ib_poll_handler() in the future,
> revert this patch.
>
> Link: https://lore.kernel.org/netdev/20220301105332.GA9417@linux.alibaba.com/
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Suggested-by: Karsten Graul <kgraul@linux.ibm.com>
> Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
> ---
> net/smc/smc_wr.c | 49 +++++++++++++++++++++---------------------------
> 1 file changed, 21 insertions(+), 28 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2022-03-04 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 9:17 [PATCH net-next] Revert "net/smc: don't req_notify until all CQEs drained" Dust Li
2022-03-04 17:12 ` Leon Romanovsky [this message]
2022-03-06 11:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiJIjNu/OO1o11Vc@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=guangguan.wang@linux.alibaba.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox