From: Andrew Lunn <andrew@lunn.ch>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, davem@davemloft.net,
kuba@kernel.org
Subject: Re: [PATCH net-next] net: lan966x: Improve the CPU TX bitrate.
Date: Tue, 8 Mar 2022 22:36:09 +0100 [thread overview]
Message-ID: <YifMSUA/uZoPnpf1@lunn.ch> (raw)
In-Reply-To: <20220308165727.4088656-1-horatiu.vultur@microchip.com>
> static int lan966x_port_inj_ready(struct lan966x *lan966x, u8 grp)
> {
> - u32 val;
> + unsigned long time = jiffies + usecs_to_jiffies(READL_TIMEOUT_US);
> + int ret = 0;
>
> - return readx_poll_timeout_atomic(lan966x_port_inj_status, lan966x, val,
> - QS_INJ_STATUS_FIFO_RDY_GET(val) & BIT(grp),
> - READL_SLEEP_US, READL_TIMEOUT_US);
> + while (!(lan_rd(lan966x, QS_INJ_STATUS) &
> + QS_INJ_STATUS_FIFO_RDY_SET(BIT(grp)))) {
> + if (time_after(jiffies, time)) {
> + ret = -ETIMEDOUT;
> + break;
> + }
Did you try setting READL_SLEEP_US to 0? readx_poll_timeout_atomic()
explicitly supports that.
Andrew
next prev parent reply other threads:[~2022-03-08 21:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 16:57 [PATCH net-next] net: lan966x: Improve the CPU TX bitrate Horatiu Vultur
2022-03-08 21:36 ` Andrew Lunn [this message]
2022-03-08 22:30 ` Horatiu Vultur
2022-03-08 22:46 ` David Laight
2022-03-09 9:11 ` 'Horatiu Vultur'
2022-03-09 9:57 ` David Laight
2022-03-09 12:16 ` 'Horatiu Vultur'
2022-03-09 0:40 ` Jakub Kicinski
2022-03-09 9:14 ` Horatiu Vultur
2022-03-09 13:11 ` Andrew Lunn
2022-03-09 22:05 ` Horatiu Vultur
2022-03-10 0:37 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YifMSUA/uZoPnpf1@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).