From: Leon Romanovsky <leonro@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
"Sridhar Samudrala" <sridhar.samudrala@intel.com>,
<netdev@vger.kernel.org>, <sudheer.mogilappagari@intel.com>,
<amritha.nambiar@intel.com>, <jiri@nvidia.com>,
Bharathi Sreenivas <bharathi.sreenivas@intel.com>
Subject: Re: [PATCH net-next 1/2] devlink: Allow parameter registration/unregistration during runtime
Date: Fri, 11 Mar 2022 08:21:01 +0200 [thread overview]
Message-ID: <YirqTaKPzmKLy6EB@unreal> (raw)
In-Reply-To: <20220310203348.40663525@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Mar 10, 2022 at 08:33:48PM -0800, Jakub Kicinski wrote:
> On Thu, 10 Mar 2022 15:12:34 -0800 Tony Nguyen wrote:
> > From: Sridhar Samudrala <sridhar.samudrala@intel.com>
> >
> > commit 7a690ad499e7 ("devlink: Clean not-executed param notifications")
> > added ASSERTs and removed notifications when devlink parameters are
> > registered by the drivers after the associated devlink instance is
> > already registered.
> > The next patch in this series adds a feature in 'ice' driver that is
> > only enabled when ADQ queue groups are created and introduces a
> > devlink parameter to configure this feature per queue group.
> >
> > To allow dynamic parameter registration/unregistration during runtime,
> > revert the changes added by the above commit.
>
> I'm pretty sure what you're doing is broken. You should probably wait
> until my patches to allow explicit devlink locking are merged and build
> on top of that.
Yes, it is broken, but I don't see how your devlink locking series will
help here. IMHO, devlink_params_register() should not be dynamic [1].
Thanks
[1] https://lore.kernel.org/all/YirRQWT7dtTV4fwG@unreal
next prev parent reply other threads:[~2022-03-11 6:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 23:12 [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-03-10 Tony Nguyen
2022-03-10 23:12 ` [PATCH net-next 1/2] devlink: Allow parameter registration/unregistration during runtime Tony Nguyen
2022-03-11 4:33 ` Jakub Kicinski
2022-03-11 6:21 ` Leon Romanovsky [this message]
2022-03-11 6:28 ` Jakub Kicinski
2022-03-10 23:12 ` [PATCH net-next 2/2] ice: Add inline flow director support for channels Tony Nguyen
2022-03-11 4:34 ` Jakub Kicinski
2022-03-11 18:36 ` Samudrala, Sridhar
2022-03-11 20:49 ` Jakub Kicinski
2022-03-13 22:11 ` Samudrala, Sridhar
2022-03-14 20:11 ` Jakub Kicinski
2022-03-11 4:34 ` [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-03-10 Leon Romanovsky
2022-03-11 15:19 ` Samudrala, Sridhar
2022-03-11 16:24 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YirqTaKPzmKLy6EB@unreal \
--to=leonro@nvidia.com \
--cc=amritha.nambiar@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bharathi.sreenivas@intel.com \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox