From: Ido Schimmel <idosch@idosch.org>
To: Hans Schultz <schultz.hans@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Ivan Vecera <ivecera@redhat.com>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Ido Schimmel <idosch@nvidia.com>,
linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 1/3] net: bridge: add fdb flag to extent locked port feature
Date: Tue, 15 Mar 2022 13:00:12 +0200 [thread overview]
Message-ID: <YjBxvM+rYSMP8UNy@shredder> (raw)
In-Reply-To: <86h77zha8b.fsf@gmail.com>
On Tue, Mar 15, 2022 at 09:48:52AM +0100, Hans Schultz wrote:
> On mån, mar 14, 2022 at 17:30, Ido Schimmel <idosch@idosch.org> wrote:
> > On Thu, Mar 10, 2022 at 03:23:18PM +0100, Hans Schultz wrote:
> >> @@ -94,8 +95,16 @@ int br_handle_frame_finish(struct net *net, struct sock *sk, struct sk_buff *skb
> >> br_fdb_find_rcu(br, eth_hdr(skb)->h_source, vid);
> >>
> >> if (!fdb_src || READ_ONCE(fdb_src->dst) != p ||
> >> - test_bit(BR_FDB_LOCAL, &fdb_src->flags))
> >> + test_bit(BR_FDB_LOCAL, &fdb_src->flags)) {
> >> + if (!fdb_src) {
> >> + set_bit(BR_FDB_ENTRY_LOCKED, &flags);
> >
> > This flag is read-only for user space, right? That is, the kernel needs
> > to reject it during netlink policy validation.
> >
>
> Yes, the flag is only readable from user space, unless there is a wish
> to change that.
OK, so please spell it out in the commit message so that it is clear the
flag can only be set by the kernel.
next prev parent reply other threads:[~2022-03-15 11:00 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 14:23 [PATCH net-next 0/3] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Hans Schultz
2022-03-10 14:23 ` [PATCH net-next 1/3] net: bridge: add fdb flag to extent locked port feature Hans Schultz
2022-03-10 14:42 ` Nikolay Aleksandrov
2022-03-10 15:38 ` Hans Schultz
2022-03-10 15:57 ` Nikolay Aleksandrov
2022-03-10 16:11 ` Hans Schultz
2022-03-10 16:14 ` Nikolay Aleksandrov
2022-03-10 16:33 ` Hans Schultz
2022-03-14 15:30 ` Ido Schimmel
2022-03-15 8:48 ` Hans Schultz
2022-03-15 11:00 ` Ido Schimmel [this message]
2022-03-10 14:23 ` [PATCH net-next 2/3] net: switchdev: add support for offloading of fdb locked flag Hans Schultz
2022-03-10 14:23 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: mac-auth/MAB implementation Hans Schultz
2022-03-10 14:28 ` Vladimir Oltean
2022-03-10 15:00 ` Hans Schultz
2022-03-10 15:07 ` Vladimir Oltean
2022-03-10 15:51 ` Hans Schultz
2022-03-10 16:05 ` Vladimir Oltean
2022-03-10 16:40 ` Hans Schultz
2022-03-10 15:57 ` Hans Schultz
2022-03-14 10:46 ` Hans Schultz
2022-03-16 23:34 ` Vladimir Oltean
2022-03-17 8:52 ` Hans Schultz
2022-03-17 14:19 ` Andrew Lunn
2022-03-17 15:36 ` Vladimir Oltean
2022-03-17 16:07 ` Hans Schultz
2022-03-17 16:18 ` Vladimir Oltean
2022-03-17 16:58 ` Hans Schultz
2022-03-17 17:20 ` Vladimir Oltean
2022-03-18 10:04 ` Hans Schultz
2022-03-18 12:14 ` Vladimir Oltean
2022-03-18 13:10 ` Hans Schultz
2022-03-18 13:19 ` Vladimir Oltean
2022-03-22 11:01 ` Hans Schultz
2022-03-22 11:08 ` Vladimir Oltean
2022-03-22 13:21 ` Hans Schultz
2022-03-22 14:47 ` Hans Schultz
2022-03-23 10:13 ` Hans Schultz
2022-03-23 10:16 ` Vladimir Oltean
2022-03-23 10:46 ` Hans Schultz
2022-03-23 10:57 ` Hans Schultz
2022-03-23 11:21 ` Vladimir Oltean
2022-03-23 11:43 ` Hans Schultz
2022-03-23 11:54 ` Vladimir Oltean
2022-03-21 14:51 ` Hans Schultz
2022-03-10 14:54 ` Andrew Lunn
2022-03-11 7:59 ` Hans Schultz
2022-03-14 15:50 ` [PATCH net-next 0/3] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Ido Schimmel
2022-03-15 8:59 ` Hans Schultz
2022-03-15 11:11 ` Ido Schimmel
2022-03-17 0:18 ` Florian Fainelli
2022-03-17 8:29 ` Hans Schultz
2022-03-17 18:42 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjBxvM+rYSMP8UNy@shredder \
--to=idosch@idosch.org \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=schultz.hans@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox