From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED82BC433F5 for ; Thu, 17 Mar 2022 08:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230430AbiCQIjL (ORCPT ); Thu, 17 Mar 2022 04:39:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbiCQIjK (ORCPT ); Thu, 17 Mar 2022 04:39:10 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA3B02711 for ; Thu, 17 Mar 2022 01:37:52 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id gb39so9151445ejc.1 for ; Thu, 17 Mar 2022 01:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IFPHeQmfbxtnmqSf24rcU4k06iHQfkREKrLRep1YmfM=; b=nSIHTwOOCs0K8GDql6D61gg39i/Oe4bj53WAkzDICZH9sUKrpLm7dN2RP79CJSr8wq GomGqjPRcSgTmwZe/X7n9qRSYYvk7lKyS0aISJ62jzbgw4v2Sbbtc/2aF529LHVv+zWg QoSyrGeA6bm+AB6yvTIdQSUnywr3mlnIgD/OEvs2N7KgztagdW9l/hgsTmrLMwWCQHd5 V1xmJ6ZIJSPJ7/ddW4pYcisKN9usYta/6X5ECri6Qx1zHyPfCPbRWG/8TuEwsNQE+yH/ ndYGZXuEfY8bkaRz6OvutOY4G40LR/cV7VnmTS/dUIAcjRYmgW5ezBjMpi2WcNwGNd5A YEIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IFPHeQmfbxtnmqSf24rcU4k06iHQfkREKrLRep1YmfM=; b=EKAxD1Vh4TR0mDPbetUnpOB75zB//Dm9bPbEJjGMSxGGNxx3ogXdPMn/KZScFQxAv2 +UPkECLpk0Sm/agvkHJ8peWuhQAoJ/aRe3bQ+g7FoStMyo+OxO4ujL8dWWWOwwd6+fZr ULqgv8NzkTrsahPWmzbZT7da9dyzM54hE69TwPCvg+sKv7fwvGxYtPWRz9Se7nkFk85d mFydcAwjAs7O4t5e3kIDqHGWupD0PsOfK/2fYnixkkjTaoQrBNiAloWi1sR6pQSPJMhn R56RRuHHj8k5R7CWS9mX7I60NSRdZe8V6vtN5nVR3crcx8geUuSEzaJrP82XhvJhMBbv t2Eg== X-Gm-Message-State: AOAM530M9TmXcrm/pFgET9JB3iEezSY0TcakYaYHV1qLjmsPiGP55SK3 YGiDJyjsQNji5vudSFNHG7u4ZA== X-Google-Smtp-Source: ABdhPJy0K5h6ACQl1Z3dLBExvsQC6tZOgEsDBypJg8DmPqduKnja92ducnttQKub63wDbOX5G5CoKg== X-Received: by 2002:a17:906:1656:b0:6cf:571c:f91d with SMTP id n22-20020a170906165600b006cf571cf91dmr3246874ejd.377.1647506271290; Thu, 17 Mar 2022 01:37:51 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id dn4-20020a17090794c400b006dbec4f4acbsm2036332ejc.6.2022.03.17.01.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 01:37:50 -0700 (PDT) Date: Thu, 17 Mar 2022 09:37:50 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, leonro@nvidia.com, saeedm@nvidia.com, idosch@idosch.org, michael.chan@broadcom.com, simon.horman@corigine.com Subject: Re: [PATCH net-next 5/5] devlink: hold the instance lock during eswitch_mode callbacks Message-ID: References: <20220317042023.1470039-1-kuba@kernel.org> <20220317042023.1470039-6-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220317042023.1470039-6-kuba@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Mar 17, 2022 at 05:20:23AM CET, kuba@kernel.org wrote: >Make the devlink core hold the instance lock during eswitch_mode >callbacks. Cheat in case of mlx5 (see the cover letter). > >Signed-off-by: Jakub Kicinski Looks fine. Reviewed-by: Jiri Pirko I agree with Leon that it would be better to have the "TODO" comment elsewhere.