Re: [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit

Ira Weiny
2022-03-17T03:34:18Z

On Wed, Mar 16, 2022 at 12:20:01PM -0700, Randy Dunlap wrote:
> There are a number of drivers that use "module_init(init)" and
> "module_exit(exit)", which are anonymous names and can lead to
> confusion or ambiguity when reading System.map, crashes/oops/bugs,
> or an initcall_debug log.
>
> Give each of these init and exit functions unique driver-specific
> names to eliminate the anonymous names.

I'm not fully sure about the Fixes tags but I don't see that it hurts anything.

For the series:

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

>
> Example 1: (System.map)
> ffffffff832fc78c t init
> ffffffff832fc79e t init
> ffffffff832fc8f8 t init
> ffffffff832fca05 t init
> ffffffff832fcbd2 t init
> ffffffff83328f0e t init
> ffffffff8332c5b1 t init
> ffffffff8332d9eb t init
> ffffffff8332f0aa t init
> ffffffff83330e25 t init
> ffffffff833317a5 t init
> ffffffff8333dd6b t init
>
> Example 2: (initcall_debug log)
> calling init+0x0/0x12 @ 1
> initcall init+0x0/0x12 returned 0 after 15 usecs
> calling init+0x0/0x60 @ 1
> initcall init+0x0/0x60 returned 0 after 2 usecs
> calling init+0x0/0x9a @ 1
> initcall init+0x0/0x9a returned 0 after 74 usecs
> calling init+0x0/0x73 @ 1
> initcall init+0x0/0x73 returned 0 after 6 usecs
> calling init+0x0/0x73 @ 1
> initcall init+0x0/0x73 returned 0 after 4 usecs
> calling init+0x0/0xf5 @ 1
> initcall init+0x0/0xf5 returned 0 after 27 usecs
> calling init+0x0/0x7d @ 1
> initcall init+0x0/0x7d returned 0 after 11 usecs
> calling init+0x0/0xc9 @ 1
> initcall init+0x0/0xc9 returned 0 after 19 usecs
> calling init+0x0/0x9d @ 1
> initcall init+0x0/0x9d returned 0 after 37 usecs
> calling init+0x0/0x63f @ 1
> initcall init+0x0/0x63f returned 0 after 411 usecs
> calling init+0x0/0x171 @ 1
> initcall init+0x0/0x171 returned 0 after 61 usecs
> calling init+0x0/0xef @ 1
> initcall init+0x0/0xef returned 0 after 3 usecs
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Amit Shah <amit@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Eli Cohen <eli@mellanox.com>
> Cc: Saeed Mahameed <saeedm@nvidia.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
> Cc: Florian Westphal <fw@strlen.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Krzysztof Opasiak <k.opasiak@samsung.com>
> Cc: Igor Kotrasinski <i.kotrasinsk@samsung.com>
> Cc: Valentina Manea <valentina.manea.m@gmail.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
> Cc: Joachim Fritschi <jfritschi@freenet.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Karol Herbst <karolherbst@gmail.com>
> Cc: Pekka Paalanen <ppaalanen@gmail.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: netfilter-devel@vger.kernel.org
> Cc: coreteam@netfilter.org
> Cc: netdev@vger.kernel.org
> Cc: linux-block@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-rdma@vger.kernel.org
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Cc: nouveau@lists.freedesktop.org
> Cc: virtualization@lists.linux-foundation.org
> Cc: x86@kernel.org
>
> patches:
> [PATCH 1/9] virtio_blk: eliminate anonymous module_init & module_exit
> [PATCH 2/9] virtio_console: eliminate anonymous module_init & module_exit
> [PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit
> [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit
> [PATCH 5/9] virtio-scsi: eliminate anonymous module_init & module_exit
> [PATCH 6/9] usb: gadget: eliminate anonymous module_init & module_exit
> [PATCH 7/9] usb: usbip: eliminate anonymous module_init & module_exit
> [PATCH 8/9] x86/crypto: eliminate anonymous module_init & module_exit
> [PATCH 9/9] testmmiotrace: eliminate anonymous module_init & module_exit
>
> diffstat:
> arch/x86/crypto/blowfish_glue.c | 8 ++++----
> arch/x86/crypto/camellia_glue.c | 8 ++++----
> arch/x86/crypto/serpent_avx2_glue.c | 8 ++++----
> arch/x86/crypto/twofish_glue.c | 8 ++++----
> arch/x86/crypto/twofish_glue_3way.c | 8 ++++----
> arch/x86/mm/testmmiotrace.c | 8 ++++----
> drivers/block/virtio_blk.c | 8 ++++----
> drivers/char/virtio_console.c | 8 ++++----
> drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 ++++----
> drivers/scsi/virtio_scsi.c | 8 ++++----
> drivers/usb/gadget/legacy/inode.c | 8 ++++----
> drivers/usb/gadget/legacy/serial.c | 10 +++++-----
> drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++----
> drivers/usb/usbip/vudc_main.c | 8 ++++----
> net/ipv4/netfilter/nf_nat_h323.c | 8 ++++----
> 15 files changed, 61 insertions(+), 61 deletions(-)