From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC56CC433FE for ; Fri, 18 Mar 2022 18:24:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240086AbiCRSZq (ORCPT ); Fri, 18 Mar 2022 14:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238890AbiCRSZg (ORCPT ); Fri, 18 Mar 2022 14:25:36 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AE3CEDF2F; Fri, 18 Mar 2022 11:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647627857; x=1679163857; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=wpIS4R443Nce+z/m4Mc2carJ5M+X4U+cG/spU7q0iJU=; b=MBb9M1/vjaNnIKvN8fe/t0g9yLSMQIIQPN9P1ZDa04QpAGJGvLqt6Py1 cikhcOfVVFRghA2XRHU4B2rHS4Vl27I+LONmU/hWbE6rPNTfkeBZejJpw wNFWsnvA0uQVcSeGNAD4qMdC3F/oR2IIl5G67CPhyJGqnu1l6SAINfFbl c+JPjC7e/ENy2GJds6OYdGuWPn9NXInB9OWMhUwnfhQUb5LyAH7YzEk6y z6OHoa66psdsHwIXZKuTdKybAoFGs6KzqSiWE6H135jaH6z+h70/PFkeO 67hCvIKfenfSIyYGWfzxUX9t+UzsIwHN8TiLnXvAPRaZ4dB8BcY0JUpvJ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10290"; a="320404134" X-IronPort-AV: E=Sophos;i="5.90,192,1643702400"; d="scan'208";a="320404134" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2022 11:12:14 -0700 X-IronPort-AV: E=Sophos;i="5.90,192,1643702400"; d="scan'208";a="550837171" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2022 11:12:08 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nVH4S-002Ns0-Qz; Fri, 18 Mar 2022 20:11:28 +0200 Date: Fri, 18 Mar 2022 20:11:28 +0200 From: Andy Shevchenko To: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= Cc: Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "'Rafael J . Wysocki '" , Wolfram Sang , Peter Rosin , Russell King , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Hans de Goede , Thomas Petazzoni , Alexandre Belloni , Allan Nielsen , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 4/6] i2c: mux: pinctrl: remove CONFIG_OF dependency and use fwnode API Message-ID: References: <20220318160059.328208-1-clement.leger@bootlin.com> <20220318160059.328208-5-clement.leger@bootlin.com> <20220318175630.0e235f41@fixe.home> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220318175630.0e235f41@fixe.home> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 18, 2022 at 05:56:30PM +0100, Clément Léger wrote: > Le Fri, 18 Mar 2022 18:28:45 +0200, > Andy Shevchenko a écrit : > > On Fri, Mar 18, 2022 at 05:00:50PM +0100, Clément Léger wrote: > > > In order to use i2c muxes with software_node when added with a struct > > > mfd_cell, switch to fwnode API. The fwnode layer will allow to use this > > > with both device_node and software_node. > > > > > - struct device_node *np = dev->of_node; > > > + struct fwnode_handle *np = dev_fwnode(dev); > > > > np is now a misleading name. Use fwnode. > > Ok I thought np was meaning "node pointer" and it looked like okay to > avoid avoid a diff that is too huge. But agreed, I'll rename that. It's rather "in practice", np stands for "OF node pointer", while fwnode stands for "firmware node handle". -- With Best Regards, Andy Shevchenko