From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH net-next v3 3/3] net: mdio: mscc-miim: add lan966x internal phy reset support
Date: Sat, 19 Mar 2022 01:16:19 +0100 [thread overview]
Message-ID: <YjUg01ysbonU7L/p@lunn.ch> (raw)
In-Reply-To: <20220318201324.1647416-4-michael@walle.cc>
On Fri, Mar 18, 2022 at 09:13:24PM +0100, Michael Walle wrote:
> The LAN966x has two internal PHYs which are in reset by default. The
> driver already supported the internal PHYs of the SparX-5. Now add
> support for the LAN966x, too. Add a new compatible to distinguish them.
>
> The LAN966x has additional control bits in this register, thus convert
> the regmap_write() to regmap_update_bits() to leave the remaining bits
> untouched. This doesn't change anything for the SparX-5 SoC, because
> there, the register consists only of reset bits.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-03-19 0:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 20:13 [PATCH net-next v3 0/3] net: mscc-miim: add integrated PHY reset support Michael Walle
2022-03-18 20:13 ` [PATCH net-next v3 1/3] dt-bindings: net: mscc-miim: add lan966x compatible Michael Walle
2022-03-18 20:13 ` [PATCH net-next v3 2/3] net: mdio: mscc-miim: replace magic numbers for the bus reset Michael Walle
2022-03-19 0:14 ` Andrew Lunn
2022-03-18 20:13 ` [PATCH net-next v3 3/3] net: mdio: mscc-miim: add lan966x internal phy reset support Michael Walle
2022-03-19 0:16 ` Andrew Lunn [this message]
2022-03-22 6:00 ` [PATCH net-next v3 0/3] net: mscc-miim: add integrated PHY " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjUg01ysbonU7L/p@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).