* [PATCH -next] net: wwan: qcom_bam_dmux: fix wrong pointer passed to IS_ERR()
@ 2022-03-19 3:24 Yang Yingliang
2022-03-19 11:38 ` Stephan Gerhold
2022-03-22 8:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-03-19 3:24 UTC (permalink / raw)
To: linux-kernel, netdev, linux-arm-msm; +Cc: davem, stephan
It should check dmux->tx after calling dma_request_chan().
Fixes: 21a0ffd9b38c ("net: wwan: Add Qualcomm BAM-DMUX WWAN network driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/wwan/qcom_bam_dmux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wwan/qcom_bam_dmux.c b/drivers/net/wwan/qcom_bam_dmux.c
index 5dfa2eba6014..17d46f4d2913 100644
--- a/drivers/net/wwan/qcom_bam_dmux.c
+++ b/drivers/net/wwan/qcom_bam_dmux.c
@@ -755,7 +755,7 @@ static int __maybe_unused bam_dmux_runtime_resume(struct device *dev)
return 0;
dmux->tx = dma_request_chan(dev, "tx");
- if (IS_ERR(dmux->rx)) {
+ if (IS_ERR(dmux->tx)) {
dev_err(dev, "Failed to request TX DMA channel: %pe\n", dmux->tx);
dmux->tx = NULL;
bam_dmux_runtime_suspend(dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] net: wwan: qcom_bam_dmux: fix wrong pointer passed to IS_ERR()
2022-03-19 3:24 [PATCH -next] net: wwan: qcom_bam_dmux: fix wrong pointer passed to IS_ERR() Yang Yingliang
@ 2022-03-19 11:38 ` Stephan Gerhold
2022-03-22 8:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Stephan Gerhold @ 2022-03-19 11:38 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, netdev, linux-arm-msm, davem
On Sat, Mar 19, 2022 at 11:24:50AM +0800, Yang Yingliang wrote:
> It should check dmux->tx after calling dma_request_chan().
>
> Fixes: 21a0ffd9b38c ("net: wwan: Add Qualcomm BAM-DMUX WWAN network driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Good catch, thanks!
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
I'm a bit confused by the -next suffix in the subject though,
this should probably go into "net" (not "net-next") since it is a fix.
> ---
> drivers/net/wwan/qcom_bam_dmux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wwan/qcom_bam_dmux.c b/drivers/net/wwan/qcom_bam_dmux.c
> index 5dfa2eba6014..17d46f4d2913 100644
> --- a/drivers/net/wwan/qcom_bam_dmux.c
> +++ b/drivers/net/wwan/qcom_bam_dmux.c
> @@ -755,7 +755,7 @@ static int __maybe_unused bam_dmux_runtime_resume(struct device *dev)
> return 0;
>
> dmux->tx = dma_request_chan(dev, "tx");
> - if (IS_ERR(dmux->rx)) {
> + if (IS_ERR(dmux->tx)) {
> dev_err(dev, "Failed to request TX DMA channel: %pe\n", dmux->tx);
> dmux->tx = NULL;
> bam_dmux_runtime_suspend(dev);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] net: wwan: qcom_bam_dmux: fix wrong pointer passed to IS_ERR()
2022-03-19 3:24 [PATCH -next] net: wwan: qcom_bam_dmux: fix wrong pointer passed to IS_ERR() Yang Yingliang
2022-03-19 11:38 ` Stephan Gerhold
@ 2022-03-22 8:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-03-22 8:50 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, netdev, linux-arm-msm, davem, stephan
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Sat, 19 Mar 2022 11:24:50 +0800 you wrote:
> It should check dmux->tx after calling dma_request_chan().
>
> Fixes: 21a0ffd9b38c ("net: wwan: Add Qualcomm BAM-DMUX WWAN network driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/wwan/qcom_bam_dmux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [-next] net: wwan: qcom_bam_dmux: fix wrong pointer passed to IS_ERR()
https://git.kernel.org/netdev/net/c/6b3c74550224
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-22 8:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-19 3:24 [PATCH -next] net: wwan: qcom_bam_dmux: fix wrong pointer passed to IS_ERR() Yang Yingliang
2022-03-19 11:38 ` Stephan Gerhold
2022-03-22 8:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).