Re: [PATCH net-next] net: mvneta: add support for page_pool_get_stats

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

> Hi Andrew
> 
> On Wed, 6 Apr 2022 at 15:49, Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Tue, Apr 05, 2022 at 10:32:12PM +0200, Lorenzo Bianconi wrote:
> > > Introduce support for the page_pool_get_stats API to mvneta driver.
> > > If CONFIG_PAGE_POOL_STATS is enabled, ethtool will report page pool
> > > stats.
> >
> > Hi Lorenzo
> >
> > There are a lot of #ifdef in this patch. They are generally not
> > liked. What does the patch actually depend on? mnveta has a select
> > PAGE_POOL so the page pool itself should always be available?
> 
> The stats are on a different Kconfig since we wanted to allow people
> opt out if they were worried about performance.  However this is not a
> 10gbit interface and I doubt there will be any measurable hit.  I
> think selecting PAGE_POOL_STATS for the driver makes sense and will
> make the code easier to follow.

Hi Andrew and Ilias,

I just kept the same approach used for mlx driver but I am fine to always
select PAGE_POOL_STATS for mvneta. I will fix it in v2.

Regards,
Lorenzo

> 
> Thanks
> /Ilias
> >
> >           Andrew

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]