From: Luis Chamberlain <mcgrof@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: xiangxia.m.yue@gmail.com, netdev@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
"David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Dmitry Vyukov <dvyukov@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Lorenz Bauer <lmb@cloudflare.com>,
Akhmat Karakotov <hmukos@yandex-team.ru>
Subject: Re: [net-next RESEND v2] net: core: use shared sysctl macro
Date: Wed, 6 Apr 2022 14:17:43 -0700 [thread overview]
Message-ID: <Yk4Dd14KCgpqWgtg@bombadil.infradead.org> (raw)
In-Reply-To: <20220406140629.7cad841b@kernel.org>
On Wed, Apr 06, 2022 at 02:06:29PM -0700, Jakub Kicinski wrote:
> On Wed, 6 Apr 2022 13:46:02 -0700 Luis Chamberlain wrote:
> > > sysctl-next makes a lot of sense, but I'm worried about conflicts.
> >
> > I can try to deal with them as I can send the pull request to Linus towards
> > the end of the merge window.
>
> Do you mean that your -next branch is unstable and can be rebased?
Yes as I had no need / many users other than to get testing done before I
send a pull requst to Linus. The other users are developers sending
random updates with the latest efforts to clean up kernel/sysctl.c and
these sorts of changes. But it would seem that should stop and I should
make it stable.
> Often people keep their -next branches stable, and then only Linus
> can deal with the conflict (with linux-next's help).
I missed the v5.18 merge window and I hadn't rebased after Linus
released v5.18-rc1 and so I had to rebase now either way too.
> > > Would you be able to spin up a stable branch based on -rc1 so we
> > > can pull it into net-next as well?
> >
> > Yes, absolutely. Just pushed, but I should note that linux-next already
> > takes in sysctl-next. And there are non-networking changes that are
> > in sysctl-next.
>
> What I mean by a stable branch is a separate branch on top of -rc1 with
> just this patch/series, which we can pull into net-next and you can
> pull into sysctl-next. That way this change will appear with the same
> commit id in both trees and git will deal with it smoothly.
Ah yes, I hadn't needed to make sysctl-next stable but indeed it would
make sense given what you are indicating.
>
> > Does net-next go to Linus or is it just to help with
> > developers so they get something more close to linux-next but not as
> > insane?
>
> net-next goes to Linus and it's "stable" by which I mean no rebasing
> or hard pushing.
I can commit to making sysctl-next to make this coordination easier. It
make sense.
Luis
next prev parent reply other threads:[~2022-04-06 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 12:42 [net-next RESEND v2] net: core: use shared sysctl macro xiangxia.m.yue
2022-04-06 16:20 ` Luis Chamberlain
2022-04-06 19:16 ` Jakub Kicinski
2022-04-06 20:46 ` Luis Chamberlain
2022-04-06 21:06 ` Jakub Kicinski
2022-04-06 21:17 ` Luis Chamberlain [this message]
2022-04-06 19:25 ` Jakub Kicinski
2022-04-07 12:50 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk4Dd14KCgpqWgtg@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=hmukos@yandex-team.ru \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=lmb@cloudflare.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=xiangxia.m.yue@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).