netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
	corbet@lwn.net, bpf@vger.kernel.org, linux-doc@vger.kernel.org,
	f.fainelli@gmail.com
Subject: Re: [PATCH net 09/13] docs: netdev: make the testing requirement more stringent
Date: Sun, 27 Mar 2022 18:42:59 +0200	[thread overview]
Message-ID: <YkCUEwZI0jUmamPg@lunn.ch> (raw)
In-Reply-To: <20220327025400.2481365-10-kuba@kernel.org>

On Sat, Mar 26, 2022 at 07:53:56PM -0700, Jakub Kicinski wrote:
> These days we often ask for selftests so let's update our
> testing requirements.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  Documentation/networking/netdev-FAQ.rst | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/networking/netdev-FAQ.rst b/Documentation/networking/netdev-FAQ.rst
> index 85a0af5dca65..26110201f301 100644
> --- a/Documentation/networking/netdev-FAQ.rst
> +++ b/Documentation/networking/netdev-FAQ.rst
> @@ -196,11 +196,15 @@ as possible alternative mechanisms.
>  
>  What level of testing is expected before I submit my change?
>  ------------------------------------------------------------
> -If your changes are against ``net-next``, the expectation is that you
> -have tested by layering your changes on top of ``net-next``.  Ideally
> -you will have done run-time testing specific to your change, but at a
> -minimum, your changes should survive an ``allyesconfig`` and an
> -``allmodconfig`` build without new warnings or failures.
> +At the very minimum your changes must survive an ``allyesconfig`` and an
> +``allmodconfig`` build with ``W=1`` set without new warnings or failures.

Doesn't the patchwork buildbot also have C=1 ? You have been pointing
out failures for C=1, so it probably should be documented here.

	 Andrew

  reply	other threads:[~2022-03-27 16:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-27  2:53 [PATCH net 00/13] docs: update and move the netdev-FAQ Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 01/13] docs: netdev: replace references to old archives Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 02/13] docs: netdev: minor reword Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 03/13] docs: netdev: move the patch marking section up Jakub Kicinski
2022-03-27 16:28   ` Andrew Lunn
2022-03-28 17:38     ` Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 04/13] docs: netdev: turn the net-next closed into a Warning Jakub Kicinski
2022-03-27 16:35   ` Andrew Lunn
2022-03-29  8:06   ` Martin Habets
2022-03-27  2:53 ` [PATCH net 05/13] docs: netdev: shorten the name and mention msgid for patch status Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 06/13] docs: netdev: rephrase the 'Under review' question Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 07/13] docs: netdev: rephrase the 'should I update patchwork' question Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 08/13] docs: netdev: add a question about re-posting frequency Jakub Kicinski
2022-03-27 16:40   ` Andrew Lunn
2022-03-27  2:53 ` [PATCH net 09/13] docs: netdev: make the testing requirement more stringent Jakub Kicinski
2022-03-27 16:42   ` Andrew Lunn [this message]
2022-03-28 17:51     ` Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 10/13] docs: netdev: add missing back ticks Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 11/13] docs: netdev: call out the merge window in tag checking Jakub Kicinski
2022-03-27  2:53 ` [PATCH net 12/13] docs: netdev: broaden the new vs old code formatting guidelines Jakub Kicinski
2022-03-27  2:54 ` [PATCH net 13/13] docs: netdev: move the netdev-FAQ to the process pages Jakub Kicinski
2022-03-29  4:38 ` [PATCH net 00/13] docs: update and move the netdev-FAQ Kuniyuki Iwashima
2022-03-29  4:52   ` Jakub Kicinski
2022-03-29  7:22     ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkCUEwZI0jUmamPg@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).