From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: lan966x: fix kernel oops on ioctl when I/F is down
Date: Mon, 28 Mar 2022 22:43:18 +0200 [thread overview]
Message-ID: <YkId5ssdyHH8JZ64@lunn.ch> (raw)
In-Reply-To: <1ee5aec079e3eefff8475017ff1044bf@walle.cc>
> > So rather than testing of running, it would be better to test if the
> > phydev is NULL or not.
>
> What about the following:
>
> static int lan966x_port_ioctl(struct net_device *dev, struct ifreq *ifr,
> int cmd)
> {
> struct lan966x_port *port = netdev_priv(dev);
>
> if (!phy_has_hwtstamp(dev->phydev) && port->lan966x->ptp) {
> switch (cmd) {
> case SIOCSHWTSTAMP:
> return lan966x_ptp_hwtstamp_set(port, ifr);
> case SIOCGHWTSTAMP:
> return lan966x_ptp_hwtstamp_get(port, ifr);
> }
> }
>
> if (!dev->phydev)
> return -ENODEV;
>
> return phy_mii_ioctl(dev->phydev, ifr, cmd);
Yes, that is good.
Andrew
next prev parent reply other threads:[~2022-03-28 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 13:59 [PATCH net] net: lan966x: fix kernel oops on ioctl when I/F is down Michael Walle
2022-03-28 20:43 ` Andrew Lunn [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-26 0:02 Michael Walle
2022-03-26 2:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkId5ssdyHH8JZ64@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).