From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B108C433F5 for ; Wed, 30 Mar 2022 13:59:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346485AbiC3OAu (ORCPT ); Wed, 30 Mar 2022 10:00:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245501AbiC3OAr (ORCPT ); Wed, 30 Mar 2022 10:00:47 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40D53CD316; Wed, 30 Mar 2022 06:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ekBWMhJOJrwEuMsGOrTITmAnhNKuavdbk+/QN6gEvTs=; b=YSvsl56WcO71Nuk3c5QDcSCxxy aqmLXXZtjnnXGU/x8qu7GjHoG3Gp9GlgliYoXWsgeP6v49TZjlQBa95By5+e0IYOPimXw9UdZjqAr gS3NTY/kV27ln73N0wWEoMsk4JzQkWtd5NEp2fVFXSH6qaRpO8TT+G+qmv0wSmRdd13g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nZYqC-00DK3H-O3; Wed, 30 Mar 2022 15:58:28 +0200 Date: Wed, 30 Mar 2022 15:58:28 +0200 From: Andrew Lunn To: David Laight Cc: 'Guenter Roeck' , 'Michael Walle' , Xu Yilun , Tom Rix , Jean Delvare , Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski , Paolo Abeni , "linux-hwmon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 1/5] hwmon: introduce hwmon_sanitize_name() Message-ID: References: <20220329160730.3265481-1-michael@walle.cc> <20220329160730.3265481-2-michael@walle.cc> <16d8b45eba7b44e78fa8205e6666f2bd@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > So why not error the request to created the hwmon device with > an invalid name. > The name supplied will soon get fixed - since it is a literal > string in the calling driver. It is often not a literal string in the driver, but something based on the DT description of the hardware. Andrew