From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C84CC433EF for ; Thu, 31 Mar 2022 14:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237802AbiCaOr4 (ORCPT ); Thu, 31 Mar 2022 10:47:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233883AbiCaOrt (ORCPT ); Thu, 31 Mar 2022 10:47:49 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7B0E21FC45; Thu, 31 Mar 2022 07:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qdHqQPCvCaEY29ep3FNBmeTqw9YdP41bA8ZWKcRp9uM=; b=NeyA/0q7PtDyu9hi76uQhW7+fI +AzPlCx+E8xV/KXICaUwlDHcjgsyxh5almwTV2SDOUWQ4k5b06IEAmHc6C6JyI3NCt9+Zy34g817U 2v2BLBOxkmhsHuO0MNtl0QXx3DqAGEsMj93apZKjL7N/zG5RyPNvaBrgMZ21F6Bh8b285BdjhFa0V kGpHtfuP3ed5xSCEuHrJULE/nDBaKaPV/nOJFGxFsrvdN0bsZYi+LqTpvLnMejntlspgWTVWlJhfu 3ejxi1QsmtWuHDLZQrgdGCe7lnCO6yF33efwZsJos9w+86xqUhH0M5xHKxn4KstSpdQ4GIqj6KOZO m4yNPoKg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58062) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nZw3S-0004yl-9B; Thu, 31 Mar 2022 15:45:42 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nZw3N-0007iG-My; Thu, 31 Mar 2022 15:45:37 +0100 Date: Thu, 31 Mar 2022 15:45:37 +0100 From: "Russell King (Oracle)" To: Guenter Roeck Cc: Xu Yilun , David Laight , Michael Walle , Tom Rix , Jean Delvare , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Jakub Kicinski , Paolo Abeni , "linux-hwmon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 1/5] hwmon: introduce hwmon_sanitize_name() Message-ID: References: <20220329160730.3265481-1-michael@walle.cc> <20220329160730.3265481-2-michael@walle.cc> <20220330065047.GA212503@yilunxu-OptiPlex-7050> <5029cf18c9df4fab96af13c857d2e0ef@AcuMS.aculab.com> <20220330145137.GA214615@yilunxu-OptiPlex-7050> <4973276f-ed1e-c4ed-18f9-e8078c13f81a@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4973276f-ed1e-c4ed-18f9-e8078c13f81a@roeck-us.net> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 30, 2022 at 08:23:35AM -0700, Guenter Roeck wrote: > Michael, let's just drop the changes outside drivers/hwmon from > the series, and let's keep hwmon_is_bad_char() in the include file. > Let's just document it, explaining its use case. Why? There hasn't been any objection to the change. All the discussion seems to be around the new function (this patch) rather than the actual conversions in drivers. I'm entirely in favour of cleaning this up - it irks me that we're doing exactly the same cleanup everywhere we have a hwmon. At the very least, I would be completely in favour of keeping the changes in the sfp and phy code. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!