From: Andrew Lunn <andrew@lunn.ch>
To: Ian Wienand <iwienand@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net/ethernet : set default assignment identifier to NET_NAME_ENUM
Date: Fri, 1 Apr 2022 15:13:27 +0200 [thread overview]
Message-ID: <Ykb6d3EvC2ZvRXMV@lunn.ch> (raw)
In-Reply-To: <20220401063430.1189533-1-iwienand@redhat.com>
On Fri, Apr 01, 2022 at 05:34:30PM +1100, Ian Wienand wrote:
> As noted in the original commit 685343fc3ba6 ("net: add
> name_assign_type netdev attribute")
>
> ... when the kernel has given the interface a name using global
> device enumeration based on order of discovery (ethX, wlanY, etc)
> ... are labelled NET_NAME_ENUM.
>
> That describes this case, so set the default for the devices here to
> NET_NAME_ENUM to better help userspace tools to know if they might
> like to rename them.
Hi Ian
Is this potentially an ABI change, and we will get surprises when
interfaces which were not previously renamed now are? It would be nice
to see some justification this is actually safe to do.
Andrew
next prev parent reply other threads:[~2022-04-01 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 6:34 [PATCH] net/ethernet : set default assignment identifier to NET_NAME_ENUM Ian Wienand
2022-04-01 13:13 ` Andrew Lunn [this message]
2022-04-02 0:16 ` Ian Wienand
2022-04-02 18:40 ` Andrew Lunn
2022-04-04 0:55 ` Ian Wienand
2022-04-04 12:31 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykb6d3EvC2ZvRXMV@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=iwienand@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).