From: Leon Romanovsky <leon@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH mlx5-next 4/5] net/mlx5: Remove tls vs. ktls separation as it is the same
Date: Tue, 5 Apr 2022 08:43:17 +0300 [thread overview]
Message-ID: <YkvW9SNJeb5VPmeg@unreal> (raw)
In-Reply-To: <20220405003322.afko7uo527w5j3zu@sx1>
On Mon, Apr 04, 2022 at 05:33:22PM -0700, Saeed Mahameed wrote:
> On 04 Apr 15:08, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > After removal FPGA TLS, we can remove tls->ktls indirection too,
> > as it is the same thing.
> >
> > Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> > .../net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
> > .../ethernet/mellanox/mlx5/core/en/params.c | 2 +-
> > .../mellanox/mlx5/core/en_accel/en_accel.h | 11 +--
> > .../mellanox/mlx5/core/en_accel/ktls.c | 22 ++++-
> > .../mellanox/mlx5/core/en_accel/ktls.h | 32 +++++++
> > .../mellanox/mlx5/core/en_accel/ktls_rx.c | 2 +-
> > .../en_accel/{tls_stats.c => ktls_stats.c} | 38 ++++-----
> > .../mellanox/mlx5/core/en_accel/ktls_tx.c | 18 +++-
> > .../mellanox/mlx5/core/en_accel/ktls_txrx.h | 28 +++++-
> > .../mellanox/mlx5/core/en_accel/tls.c | 70 ---------------
> > .../mellanox/mlx5/core/en_accel/tls.h | 85 -------------------
> > .../mellanox/mlx5/core/en_accel/tls_rxtx.c | 70 ---------------
> > .../mellanox/mlx5/core/en_accel/tls_rxtx.h | 85 -------------------
> > .../net/ethernet/mellanox/mlx5/core/en_main.c | 8 +-
> > .../net/ethernet/mellanox/mlx5/core/en_rx.c | 5 +-
> > .../ethernet/mellanox/mlx5/core/en_stats.c | 8 +-
> > 16 files changed, 130 insertions(+), 356 deletions(-)
> > rename drivers/net/ethernet/mellanox/mlx5/core/en_accel/{tls_stats.c => ktls_stats.c} (76%)
>
> Why not ktls_*.c => tls_*.c ?
Mostly because other drivers use _ktls_ name for this type of functionality.
Plus internally, Tariq suggested to squash everything into ktls.
>
> Since we now have one TLS implementation, it would've been easier to maybe
> repurpose TLS to be KTLS only and avoid renaming every TLS to KTLS in all
> functions and files.
>
> So just keep tls.c and all mlx5_tls_xyz functions and implement ktls
> directly in them, the renaming will be done only on the ktls implementation
> part of the code rather than in every caller.
Should I do it or keep this patch as is?
Thanks
>
> > delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
> > delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h
> > delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c
> > delete mode 100644 drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.h
> >
>
next prev parent reply other threads:[~2022-04-05 5:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 12:08 [PATCH mlx5-next 0/5] Drop Mellanox FPGA TLS support from the kernel Leon Romanovsky
2022-04-04 12:08 ` [PATCH mlx5-next 1/5] net/mlx5_fpga: Drop INNOVA TLS support Leon Romanovsky
2022-04-04 12:08 ` [PATCH mlx5-next 2/5] net/mlx5: Reliably return TLS device capabilities Leon Romanovsky
2022-04-04 12:08 ` [PATCH mlx5-next 3/5] net/mlx5: Remove indirection in TLS build Leon Romanovsky
2022-04-04 12:08 ` [PATCH mlx5-next 4/5] net/mlx5: Remove tls vs. ktls separation as it is the same Leon Romanovsky
2022-04-05 0:33 ` Saeed Mahameed
2022-04-05 5:43 ` Leon Romanovsky [this message]
2022-04-05 17:20 ` Saeed Mahameed
2022-04-05 18:32 ` Leon Romanovsky
2022-04-04 12:08 ` [PATCH mlx5-next 5/5] net/mlx5: Cleanup kTLS function names and their exposure Leon Romanovsky
2022-04-05 0:35 ` [PATCH mlx5-next 0/5] Drop Mellanox FPGA TLS support from the kernel Saeed Mahameed
2022-04-06 7:04 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkvW9SNJeb5VPmeg@unreal \
--to=leon@kernel.org \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).