From: Andrew Lunn <andrew@lunn.ch>
To: Andy Chiu <andy.chiu@sifive.com>
Cc: davem@davemloft.net, michal.simek@xilinx.com,
radhey.shyam.pandey@xilinx.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org, krzk+dt@kernel.org,
linux@armlinux.org.uk, netdev@vger.kernel.org,
devicetree@vger.kernel.org,
Greentime Hu <greentime.hu@sifive.com>,
Robert Hancock <robert.hancock@calian.com>
Subject: Re: [PATCH v8 net-next 1/4] net: axienet: setup mdio unconditionally
Date: Tue, 5 Apr 2022 14:16:57 +0200 [thread overview]
Message-ID: <YkwzOSR1yzspdCq3@lunn.ch> (raw)
In-Reply-To: <20220405091929.670951-2-andy.chiu@sifive.com>
On Tue, Apr 05, 2022 at 05:19:26PM +0800, Andy Chiu wrote:
> The call to axienet_mdio_setup should not depend on whether "phy-node"
> pressents on the DT. Besides, since `lp->phy_node` is used if PHY is in
> SGMII or 100Base-X modes, move it into the if statement. And the next patch
> will remove `lp->phy_node` from driver's private structure and do an
> of_node_put on it right away after use since it is not used elsewhere.
>
> Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
> Reviewed-by: Greentime Hu <greentime.hu@sifive.com>
> Reviewed-by: Robert Hancock <robert.hancock@calian.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-04-05 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 9:19 [PATCH v8 net-next 0/4] Fix broken link on Xilinx's AXI Ethernet in SGMII mode Andy Chiu
2022-04-05 9:19 ` [PATCH v8 net-next 1/4] net: axienet: setup mdio unconditionally Andy Chiu
2022-04-05 12:00 ` Radhey Shyam Pandey
2022-04-05 12:16 ` Andrew Lunn [this message]
2022-04-05 9:19 ` [PATCH v8 net-next 2/4] net: axienet: factor out phy_node in struct axienet_local Andy Chiu
2022-04-05 12:09 ` Radhey Shyam Pandey
2022-04-05 12:17 ` Andrew Lunn
2022-04-05 9:19 ` [PATCH v8 net-next 3/4] dt-bindings: net: add pcs-handle attribute Andy Chiu
2022-04-05 12:18 ` Andrew Lunn
2022-04-05 9:19 ` [PATCH v8 net-next 4/4] net: axiemac: use a phandle to reference pcs_phy Andy Chiu
2022-04-05 12:18 ` Andrew Lunn
2022-04-05 12:23 ` Radhey Shyam Pandey
2022-04-06 13:10 ` [PATCH v8 net-next 0/4] Fix broken link on Xilinx's AXI Ethernet in SGMII mode patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkwzOSR1yzspdCq3@lunn.ch \
--to=andrew@lunn.ch \
--cc=andy.chiu@sifive.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=greentime.hu@sifive.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=robert.hancock@calian.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).