From: Leon Romanovsky <leon@kernel.org>
To: Yinjun Zhang <yinjun.zhang@corigine.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h
Date: Wed, 20 Apr 2022 09:12:34 +0300 [thread overview]
Message-ID: <Yl+kUqyMUTIadDMz@unreal> (raw)
In-Reply-To: <20220420015952.GB4636@nj-rack01-04.nji.corigine.com>
On Wed, Apr 20, 2022 at 09:59:52AM +0800, Yinjun Zhang wrote:
> On Wed, Apr 20, 2022 at 12:00:05AM +0200, Andrew Lunn wrote:
> > On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote:
> > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > Cc: linux-pci@vger.kernel.org
> > > Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
> > > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > > ---
> > > include/linux/pci_ids.h | 2 ++
> >
> > The very top of this file says:
> >
> > * Do not add new entries to this file unless the definitions
> > * are shared between multiple drivers.
> >
> > Please add to the commit messages the two or more drivers which share
> > this definition.
>
> It will be used by ethernet and infiniband driver as we can see now,
> I'll update the commit message if you think it's a good practice.
Are you going to submit completely separated infiniband driver that has
PCI logic in drivers/infiniband without connection todrivers/net/ethernet ...?
If yes, it is very uncommon in infiniband world.
I would like to see this PCI patch submitted when it is actually used.
Thanks
>
> >
> > Thanks
> >
> > Andrew
next prev parent reply other threads:[~2022-04-20 6:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 10:02 [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h Yinjun Zhang
2022-04-19 14:23 ` Bjorn Helgaas
2022-04-20 1:46 ` Yinjun Zhang
2022-04-19 22:00 ` Andrew Lunn
2022-04-20 1:59 ` Yinjun Zhang
2022-04-20 6:12 ` Leon Romanovsky [this message]
2022-04-20 7:42 ` Yinjun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl+kUqyMUTIadDMz@unreal \
--to=leon@kernel.org \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).