From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA61C433F5 for ; Mon, 11 Apr 2022 08:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243892AbiDKI75 (ORCPT ); Mon, 11 Apr 2022 04:59:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236336AbiDKI74 (ORCPT ); Mon, 11 Apr 2022 04:59:56 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49A673EBA5 for ; Mon, 11 Apr 2022 01:57:43 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7CDE73202052; Mon, 11 Apr 2022 04:57:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 11 Apr 2022 04:57:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1649667462; x= 1649753862; bh=yNRP+BeaZ6KoeHmUkIOEOQrMJmaiMlpxTKCXBPTBYvM=; b=b Ljb6dEOxLaf4F4CwnDSZ+7lJvIcyfCLKU8wi6AeFRfUkJH8VF5TKN2ioFZJMOdzp UmLMj30sFUn/cr3Jn0bhFlZurtDJI1PwRvPBcqDfkfXe8vJ4QFjw7fyF1x2MQFjW vmWBHvO213lUfaGt+ScDUgdFUBDeTLI0db4AqlgE7pNZzawBt17jY1mX2UvWCu9C RTBYsftd61BkBKmZnHvr1REKkSBPlGnLIceV4sT0JD65CE1QFj/K2ahRgAb+91gO w1z7h8ZiTvzcOn5vvIsQcmA6gEMh/0KjfvlwDnazXtd+xoaNazGTMQH0psol/DQJ cJ0rlPN2NBHprZGTGpu/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekiedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepkfguohcuufgthhhimhhmvghluceoihguohhstghhsehiugho shgthhdrohhrgheqnecuggftrfgrthhtvghrnheptdffkeekfeduffevgeeujeffjefhte fgueeugfevtdeiheduueeukefhudehleetnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Apr 2022 04:57:41 -0400 (EDT) Date: Mon, 11 Apr 2022 11:57:39 +0300 From: Ido Schimmel To: Nikolay Aleksandrov Cc: netdev@vger.kernel.org, roopa@nvidia.com, kuba@kernel.org, davem@davemloft.net, bridge@lists.linux-foundation.org Subject: Re: [PATCH net-next 5/6] net: bridge: fdb: add support for flush filtering based on ifindex Message-ID: References: <20220409105857.803667-1-razor@blackwall.org> <20220409105857.803667-6-razor@blackwall.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409105857.803667-6-razor@blackwall.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Apr 09, 2022 at 01:58:56PM +0300, Nikolay Aleksandrov wrote: > Add support for fdb flush filtering based on destination ifindex. The > ifindex must either match a port's device ifindex or the bridge's. > > Signed-off-by: Nikolay Aleksandrov > --- > include/uapi/linux/if_bridge.h | 1 + > net/bridge/br_fdb.c | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h > index 4638d7e39f2a..67ee12586844 100644 > --- a/include/uapi/linux/if_bridge.h > +++ b/include/uapi/linux/if_bridge.h > @@ -819,6 +819,7 @@ enum { > FDB_FLUSH_NDM_STATE_MASK, > FDB_FLUSH_NDM_FLAGS, > FDB_FLUSH_NDM_FLAGS_MASK, > + FDB_FLUSH_PORT_IFINDEX, > __FDB_FLUSH_MAX > }; > #define FDB_FLUSH_MAX (__FDB_FLUSH_MAX - 1) > diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c > index 340a2ace1d5e..53208adf7474 100644 > --- a/net/bridge/br_fdb.c > +++ b/net/bridge/br_fdb.c > @@ -628,6 +628,7 @@ static const struct nla_policy br_fdb_flush_policy[FDB_FLUSH_MAX + 1] = { > [FDB_FLUSH_NDM_FLAGS] = { .type = NLA_U16 }, > [FDB_FLUSH_NDM_STATE_MASK] = { .type = NLA_U16 }, > [FDB_FLUSH_NDM_FLAGS_MASK] = { .type = NLA_U16 }, > + [FDB_FLUSH_PORT_IFINDEX] = { .type = NLA_S32 }, > }; > > int br_fdb_flush_nlattr(struct net_bridge *br, struct nlattr *fdb_flush_attr, > @@ -664,6 +665,12 @@ int br_fdb_flush_nlattr(struct net_bridge *br, struct nlattr *fdb_flush_attr, > ndm_flags_mask = nla_get_u16(fdb_flush_tb[FDB_FLUSH_NDM_FLAGS_MASK]); > desc.flags_mask |= __ndm_flags_to_fdb_flags(ndm_flags_mask); > } > + if (fdb_flush_tb[FDB_FLUSH_PORT_IFINDEX]) { > + int port_ifidx; > + > + port_ifidx = nla_get_u32(fdb_flush_tb[FDB_FLUSH_PORT_IFINDEX]); > + desc.port_ifindex = port_ifidx; Commit message says "ifindex must either match a port's device ifindex or the bridge's", but there is no validation. I realize such an operation won't flush anything, but it's cleaner to just reject it here. > + } > > br_debug(br, "flushing port ifindex: %d vlan id: %u flags: 0x%lx flags mask: 0x%lx\n", > desc.port_ifindex, desc.vlan_id, desc.flags, desc.flags_mask); > -- > 2.35.1 >