From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8C14FC433EF
	for <netdev@archiver.kernel.org>; Mon, 11 Apr 2022 14:48:36 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230356AbiDKOur (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 11 Apr 2022 10:50:47 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45560 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229508AbiDKOui (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 11 Apr 2022 10:50:38 -0400
Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B1F3220DE
        for <netdev@vger.kernel.org>; Mon, 11 Apr 2022 07:48:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=S7xTA8SeAxAQrPU93JlIt/XkXXGOBhtrqtz1YsuRNB8=; b=VYpNnEVg8d6WnehmfT4Qoo0voV
        ycOePi5HWBy08BBHBCC4Ycg2jYvy7GqlYYfEFSBFh9rwe4fqB0zhjJjlE08r2HuNPrJ8qUtF9/Koa
        v8ouvB/5uSPGuT4jj6DNsUNzqFtQUW8kTeFpI9KZPntrWFWLyf6uk95OsmADOqonj6e0=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1ndvL4-00FHDp-Hr; Mon, 11 Apr 2022 16:48:22 +0200
Date:   Mon, 11 Apr 2022 16:48:22 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Geva, Erez" <erez.geva.ext@siemens.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "Sudler, Simon" <simon.sudler@siemens.com>,
        "Meisinger, Andreas" <andreas.meisinger@siemens.com>,
        "Schild, Henning" <henning.schild@siemens.com>,
        "jan.kiszka@siemens.com" <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/1] DSA Add callback to traffic control information
Message-ID: <YlQ/tqzPiHV63781@lunn.ch>
References: <20220411131148.532520-1-erez.geva.ext@siemens.com>
 <20220411131148.532520-2-erez.geva.ext@siemens.com>
 <YlQtII8G2NE7ftsY@lunn.ch>
 <VI1PR10MB24463A87DC9BED025D377CD8ABEA9@VI1PR10MB2446.EURPRD10.PROD.OUTLOOK.COM>
 <YlQ6cm/BYbrWejW4@lunn.ch>
 <VI1PR10MB2446B93B94F897274943D1D5ABEA9@VI1PR10MB2446.EURPRD10.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <VI1PR10MB2446B93B94F897274943D1D5ABEA9@VI1PR10MB2446.EURPRD10.PROD.OUTLOOK.COM>
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> The current state of many TC callbacks does not make sense.
> May be it is time to do some cleaning?

Feel free, and if that makes your new call useful, you can get it
merged that way.

Historically, we have tried to keep the taggers independent of the
switch driver. That is not always possible. But developers do combine
the loop DSA driver with any random tag drivers at times, so please be
careful with any cleanup to ensure you check for unexpected
combinations and -EOPNOTSUPP etc.

	Andrew