From: Jiri Pirko <jiri@resnulli.us>
To: Boris Sukholitko <boris.sukholitko@broadcom.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Eric Dumazet <edumazet@google.com>,
zhang kai <zhangkaiheb@126.com>,
Yoshiki Komachi <komachi.yoshiki@gmail.com>,
Ilya Lifshits <ilya.lifshits@broadcom.com>
Subject: Re: [PATCH net-next 5/5] Consider the number of vlan tags for vlan filters
Date: Mon, 11 Apr 2022 17:34:13 +0200 [thread overview]
Message-ID: <YlRKdX+uxdjuPslp@nanopsycho> (raw)
In-Reply-To: <20220411133100.18126-6-boris.sukholitko@broadcom.com>
Mon, Apr 11, 2022 at 03:31:00PM CEST, boris.sukholitko@broadcom.com wrote:
>Currently the existence of vlan filters is conditional on the vlan
>protocol being matched in the tc rule. I.e. the following rule:
>
>tc filter add dev eth1 ingress flower vlan_prio 5
>
>is illegal because we lack protocol 802.1q in the rule.
>
>Having the num_of_vlans filter configured removes this restriction. The
>following rule becomes ok:
>
>tc filter add dev eth1 ingress flower num_of_vlans 1 vlan_prio 5
>
>because we know that the packet is single tagged.
From this patch description, I'm unable to tell what the patch is doing.
Tell the codebase what to do.
Also, in subject line of the patches, it is customary to put prefix
like: "net/sched: cls_flower:"
The the first glance, the patchset looks fine to me.
next prev parent reply other threads:[~2022-04-11 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 13:30 [PATCH net-next 0/5] flower: match on the number of vlan tags Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 1/5] Helper function for vlan ethtype checks Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 2/5] Reduce identation after is_key_vlan refactoring Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 3/5] Add number of vlan tags dissector Boris Sukholitko
2022-04-11 13:30 ` [PATCH net-next 4/5] Add number of vlan tags filter to the flower Boris Sukholitko
2022-04-11 13:31 ` [PATCH net-next 5/5] Consider the number of vlan tags for vlan filters Boris Sukholitko
2022-04-11 15:34 ` Jiri Pirko [this message]
2022-04-12 10:06 ` Boris Sukholitko
2022-04-11 14:07 ` [PATCH net-next 0/5] flower: match on the number of vlan tags Jamal Hadi Salim
2022-04-11 14:56 ` Boris Sukholitko
2022-04-12 10:54 ` Jamal Hadi Salim
2022-04-14 12:59 ` Boris Sukholitko
-- strict thread matches above, loose matches on Subject: below --
2022-03-23 10:55 Boris Sukholitko
2022-03-23 10:56 ` [PATCH net-next 5/5] Consider the number of vlan tags for vlan filters Boris Sukholitko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlRKdX+uxdjuPslp@nanopsycho \
--to=jiri@resnulli.us \
--cc=boris.sukholitko@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=ilya.lifshits@broadcom.com \
--cc=jhs@mojatatu.com \
--cc=komachi.yoshiki@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zhangkaiheb@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox