From: Andrew Lunn <andrew@lunn.ch>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: netdev@vger.kernel.org, linus.walleij@linaro.org,
alsi@bang-olufsen.dk, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
krzk+dt@kernel.org, arinc.unal@arinc9.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH net 1/2] dt-bindings: net: dsa: realtek: cleanup compatible strings
Date: Sat, 16 Apr 2022 16:13:01 +0200 [thread overview]
Message-ID: <YlrO7Q/a9bK0pWIA@lunn.ch> (raw)
In-Reply-To: <20220416062504.19005-1-luizluca@gmail.com>
On Sat, Apr 16, 2022 at 03:25:03AM -0300, Luiz Angelo Daros de Luca wrote:
> Compatible strings are used to help the driver find the chip ID/version
> register for each chip family. After that, the driver can setup the
> switch accordingly. Keep only the first supported model for each family
> as a compatible string and reference other chip models in the
> description.
It would be good to mention here that these compatible strings have
never been used in a released kernel, so it is safe to remove them.
That is the sort of information which makes the job of reviewing
patches simpler. It is great to have the answers to questions you
cannot see directly from the code in the commit message.
Andrew
next prev parent reply other threads:[~2022-04-16 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 6:25 [PATCH net 1/2] dt-bindings: net: dsa: realtek: cleanup compatible strings Luiz Angelo Daros de Luca
2022-04-16 6:25 ` [PATCH net 2/2] net: dsa: realtek: remove realtek,rtl8367s string Luiz Angelo Daros de Luca
2022-04-16 6:38 ` Arınç ÜNAL
2022-04-16 11:07 ` Alvin Šipraga
2022-04-16 11:27 ` Alvin Šipraga
2022-04-16 19:30 ` Florian Fainelli
2022-04-16 6:33 ` [PATCH net 1/2] dt-bindings: net: dsa: realtek: cleanup compatible strings Arınç ÜNAL
2022-04-16 10:57 ` Alvin Šipraga
2022-04-16 14:13 ` Andrew Lunn [this message]
2022-04-17 13:58 ` Linus Walleij
2022-04-18 23:05 ` Luiz Angelo Daros de Luca
2022-04-18 23:36 ` Luiz Angelo Daros de Luca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlrO7Q/a9bK0pWIA@lunn.ch \
--to=andrew@lunn.ch \
--cc=alsi@bang-olufsen.dk \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).