From: Solomon Tan <solomonbstoner@protonmail.ch>
To: pshelar@ovn.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] openvswitch: meter: Remove unnecessary int
Date: Mon, 18 Apr 2022 00:50:12 +0000 [thread overview]
Message-ID: <Yly1t/mE6QAGPS0e@ArchDesktop> (raw)
This patch addresses the checkpatch.pl warning that long long is
preferred over long long int.
Signed-off-by: Solomon Tan <solomonbstoner@protonmail.ch>
---
net/openvswitch/meter.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/openvswitch/meter.c b/net/openvswitch/meter.c
index 04a060ac7fdf..a790920c11d6 100644
--- a/net/openvswitch/meter.c
+++ b/net/openvswitch/meter.c
@@ -592,8 +592,8 @@ static int ovs_meter_cmd_del(struct sk_buff *skb, struct genl_info *info)
bool ovs_meter_execute(struct datapath *dp, struct sk_buff *skb,
struct sw_flow_key *key, u32 meter_id)
{
- long long int now_ms = div_u64(ktime_get_ns(), 1000 * 1000);
- long long int long_delta_ms;
+ long long now_ms = div_u64(ktime_get_ns(), 1000 * 1000);
+ long long long_delta_ms;
struct dp_meter_band *band;
struct dp_meter *meter;
int i, band_exceeded_max = -1;
@@ -622,7 +622,7 @@ bool ovs_meter_execute(struct datapath *dp, struct sk_buff *skb,
/* Make sure delta_ms will not be too large, so that bucket will not
* wrap around below.
*/
- delta_ms = (long_delta_ms > (long long int)meter->max_delta_t)
+ delta_ms = (long_delta_ms > (long long)meter->max_delta_t)
? meter->max_delta_t : (u32)long_delta_ms;
/* Update meter statistics.
@@ -645,7 +645,7 @@ bool ovs_meter_execute(struct datapath *dp, struct sk_buff *skb,
/* Update all bands and find the one hit with the highest rate. */
for (i = 0; i < meter->n_bands; ++i) {
- long long int max_bucket_size;
+ long long max_bucket_size;
band = &meter->bands[i];
max_bucket_size = band->burst_size * 1000LL;
--
2.35.3
next reply other threads:[~2022-04-18 0:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 0:50 Solomon Tan [this message]
2022-04-21 8:47 ` [PATCH] openvswitch: meter: Remove unnecessary int Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yly1t/mE6QAGPS0e@ArchDesktop \
--to=solomonbstoner@protonmail.ch \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).