public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Saeed Mahameed <saeedm@nvidia.com>
Cc: Changcheng Liu <changchengx.liu@outlook.com>,
	linux-rdma@vger.kernel.org, linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5: correct ECE offset in query qp output
Date: Mon, 2 May 2022 14:24:10 +0300	[thread overview]
Message-ID: <Ym+/WnWceotzny4f@unreal> (raw)
In-Reply-To: <OSZP286MB1629E3E8563657C551711194FEFB9@OSZP286MB1629.JPNP286.PROD.OUTLOOK.COM>

On Tue, Apr 26, 2022 at 10:06:11PM +0800, Changcheng Liu wrote:
> 
> From cd2890fc0f756d809f684768fabb34b449df6d29 Mon Sep 17 00:00:00 2001
> From: Changcheng Liu <jerrliu@nvidia.com>
> Date: Tue, 26 Apr 2022 21:28:14 +0800
> Subject: [PATCH] net/mlx5: correct ECE offset in query qp output
> 
> ECE field should be after opt_param_mask in query qp output.
> 
> Fixes: 6b646a7e4af6 ("net/mlx5: Add ability to read and write ECE options")
> Signed-off-by: Changcheng Liu <jerrliu@nvidia.com>

Saeed,

Do you plan to add new patches to mlx5-next?
This change can go to that branch as this field is not used in current
code at all.

Thanks

> 
> diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
> index 7d2d0ba82144..2e162ec2a3d3 100644
> --- a/include/linux/mlx5/mlx5_ifc.h
> +++ b/include/linux/mlx5/mlx5_ifc.h
> @@ -5180,12 +5180,11 @@ struct mlx5_ifc_query_qp_out_bits {
>  
>  	u8         syndrome[0x20];
>  
> -	u8         reserved_at_40[0x20];
> -	u8         ece[0x20];
> +	u8         reserved_at_40[0x40];
>  
>  	u8         opt_param_mask[0x20];
>  
> -	u8         reserved_at_a0[0x20];
> +	u8         ece[0x20];
>  
>  	struct mlx5_ifc_qpc_bits qpc;
>  
> -- 
> 2.27.0
> 

       reply	other threads:[~2022-05-02 11:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <OSZP286MB1629E3E8563657C551711194FEFB9@OSZP286MB1629.JPNP286.PROD.OUTLOOK.COM>
2022-05-02 11:24 ` Leon Romanovsky [this message]
2022-05-10  6:06   ` [PATCH] net/mlx5: correct ECE offset in query qp output Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ym+/WnWceotzny4f@unreal \
    --to=leon@kernel.org \
    --cc=changchengx.liu@outlook.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox