From: Andrew Lunn <andrew@lunn.ch>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] net: mdio: Mask PHY only when its ACPI node is present
Date: Thu, 21 Apr 2022 13:40:54 +0200 [thread overview]
Message-ID: <YmFCxnYdRnnk41QQ@lunn.ch> (raw)
In-Reply-To: <CAAd53p5Wwn+HOMm1Z0VWcR_WrTzRvAGZOYg4X_txugSFd+EsDQ@mail.gmail.com>
On Thu, Apr 21, 2022 at 10:58:40AM +0800, Kai-Heng Feng wrote:
> On Wed, Apr 20, 2022 at 10:47 PM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Wed, Apr 20, 2022 at 08:40:48PM +0800, Kai-Heng Feng wrote:
> > > Not all PHY has an ACPI node, for those nodes auto probing is still
> > > needed.
> >
> > Why do you need this?
> >
> > Documentation/firmware-guide/acpi/dsd/phy.rst
> >
> > There is nothing here about there being PHYs which are not listed in
> > ACPI. If you have decided to go the ACPI route, you need to list the
> > PHYs.
>
> This is for backward-compatibility. MAC can have ACPI node but PHY may
> not have one.
And if the PHY does not have an ACPI node, fall back to
mdiobus_register(). This is what of_mdiobus_register() does. If
np=NULL, it calls mdiobus_register() and skips all the OF stuff.
Andrew
next prev parent reply other threads:[~2022-04-21 11:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220420124053.853891-1-kai.heng.feng@canonical.com>
2022-04-20 12:40 ` [PATCH 1/5] net: mdio: Mask PHY only when its ACPI node is present Kai-Heng Feng
2022-04-20 14:47 ` Andrew Lunn
2022-04-21 2:58 ` Kai-Heng Feng
2022-04-21 11:40 ` Andrew Lunn [this message]
2022-04-21 12:18 ` Kai-Heng Feng
2022-04-20 12:40 ` [PATCH 2/5] net: mdio: Add "use-firmware-led" firmware property Kai-Heng Feng
2022-04-20 13:01 ` Andrew Lunn
2022-04-21 3:15 ` Kai-Heng Feng
2022-04-20 12:40 ` [PATCH 3/5] net: phy: Add helpers to save and restore firmware LED Kai-Heng Feng
2022-04-20 12:40 ` [PATCH 4/5] net: phy: marvell: Add LED accessors for Marvell 88E1510 Kai-Heng Feng
2022-04-20 15:03 ` Andrew Lunn
2022-04-21 3:11 ` Kai-Heng Feng
2022-04-21 11:51 ` Andrew Lunn
2022-04-21 12:24 ` Kai-Heng Feng
2022-04-21 12:57 ` Andrew Lunn
2022-04-22 3:49 ` Kai-Heng Feng
2022-04-20 12:40 ` [PATCH 5/5] net: stmmac: Use acpi_mdiobus_register() for ACPI based system Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmFCxnYdRnnk41QQ@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).