From: Andrew Lunn <andrew@lunn.ch>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] net: phy: marvell: Add LED accessors for Marvell 88E1510
Date: Thu, 21 Apr 2022 13:51:53 +0200 [thread overview]
Message-ID: <YmFFWd42Nol7Lrlm@lunn.ch> (raw)
In-Reply-To: <CAAd53p6UAhDC2mGkz3_HgVs7kFgCwjfu2R+9FfROhToH2R6CjA@mail.gmail.com>
> This is not feasible.
> If BIOS can define a method and restore the LED by itself, it can put
> the method inside its S3 method and I don't have to work on this at
> the first place.
So maybe just declare the BIOS as FUBAR and move on to the next issue
assigned to you.
Do we really want the maintenance burden of this code for one machines
BIOS? Maybe the better solution is to push back on the vendor and its
BIOS, tell them how they should of done this, if the BIOS wants to be
in control of the LEDs it needs to offer the methods to control the
LEDs. And then hopefully the next machine the vendor produces will
have working BIOS.
Your other option is to take part in the effort to add control of the
LEDs via the standard Linux LED subsystem. The Marvel PHY driver is
likely to be one of the first to gain support this for. So you can
then totally take control of the LED from the BIOS and put it in the
users hands. And such a solution will be applicable to many machines,
not just one.
Andrew
next prev parent reply other threads:[~2022-04-21 11:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220420124053.853891-1-kai.heng.feng@canonical.com>
2022-04-20 12:40 ` [PATCH 1/5] net: mdio: Mask PHY only when its ACPI node is present Kai-Heng Feng
2022-04-20 14:47 ` Andrew Lunn
2022-04-21 2:58 ` Kai-Heng Feng
2022-04-21 11:40 ` Andrew Lunn
2022-04-21 12:18 ` Kai-Heng Feng
2022-04-20 12:40 ` [PATCH 2/5] net: mdio: Add "use-firmware-led" firmware property Kai-Heng Feng
2022-04-20 13:01 ` Andrew Lunn
2022-04-21 3:15 ` Kai-Heng Feng
2022-04-20 12:40 ` [PATCH 3/5] net: phy: Add helpers to save and restore firmware LED Kai-Heng Feng
2022-04-20 12:40 ` [PATCH 4/5] net: phy: marvell: Add LED accessors for Marvell 88E1510 Kai-Heng Feng
2022-04-20 15:03 ` Andrew Lunn
2022-04-21 3:11 ` Kai-Heng Feng
2022-04-21 11:51 ` Andrew Lunn [this message]
2022-04-21 12:24 ` Kai-Heng Feng
2022-04-21 12:57 ` Andrew Lunn
2022-04-22 3:49 ` Kai-Heng Feng
2022-04-20 12:40 ` [PATCH 5/5] net: stmmac: Use acpi_mdiobus_register() for ACPI based system Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmFFWd42Nol7Lrlm@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).