From: Jiri Pirko <jiri@resnulli.us>
To: David Ahern <dsahern@gmail.com>
Cc: Shannon Nelson <snelson@pensando.io>,
netdev@vger.kernel.org, sthemmin@microsoft.com
Subject: Re: [patch iproute2-next] devlink: introduce -h[ex] cmdline option to allow dumping numbers in hex format
Date: Mon, 25 Apr 2022 11:31:11 +0200 [thread overview]
Message-ID: <YmZqX4adcw55qSb0@nanopsycho> (raw)
In-Reply-To: <b386dcb4-6c1e-c615-f737-e2bb3026b976@gmail.com>
Sat, Apr 23, 2022 at 02:20:06AM CEST, dsahern@gmail.com wrote:
>On 4/22/22 3:36 PM, Shannon Nelson wrote:
>>> @@ -9053,6 +9056,7 @@ int main(int argc, char **argv)
>>> { "statistics", no_argument, NULL, 's' },
>>> { "Netns", required_argument, NULL, 'N' },
>>> { "iec", no_argument, NULL, 'i' },
>>> + { "hex", no_argument, NULL, 'h' },
>>
>> Can we use 'x' instead of 'h' here? Most times '-h' means 'help', and
>> might surprise unsuspecting users when it isn't a help flag.
>>
>
>agreed. -h almost always means help
Changed in v2.
prev parent reply other threads:[~2022-04-25 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 17:16 [patch iproute2-next] devlink: introduce -h[ex] cmdline option to allow dumping numbers in hex format Jiri Pirko
2022-04-22 21:36 ` Shannon Nelson
2022-04-22 23:10 ` Stephen Hemminger
2022-04-25 9:31 ` Jiri Pirko
2022-04-23 0:20 ` David Ahern
2022-04-25 9:31 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmZqX4adcw55qSb0@nanopsycho \
--to=jiri@resnulli.us \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox