From: Andrew Lunn <andrew@lunn.ch>
To: Yuiko Oshino <yuiko.oshino@microchip.com>
Cc: woojung.huh@microchip.com, davem@davemloft.net,
netdev@vger.kernel.org, ravi.hegde@microchip.com,
UNGLinuxDriver@microchip.com
Subject: Re: [REVIEW REQUEST3 PATCH net-next 1/2] net: phy: microchip: update LAN88xx phy ID and phy ID mask.
Date: Wed, 27 Apr 2022 17:30:17 +0200 [thread overview]
Message-ID: <YmlhiQpjUMh+awJ2@lunn.ch> (raw)
In-Reply-To: <20220427115142.12642-2-yuiko.oshino@microchip.com>
On Wed, Apr 27, 2022 at 04:51:41AM -0700, Yuiko Oshino wrote:
> update LAN88xx phy ID and phy ID mask because the existing code conflicts with the LAN8742 phy.
>
> The current phy IDs on the available hardware.
> LAN8742 0x0007C130, 0x0007C131
> LAN88xx 0x0007C132
>
> Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
> ---
> drivers/net/phy/microchip.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/microchip.c b/drivers/net/phy/microchip.c
> index 9f1f2b6c97d4..131caf659ed2 100644
> --- a/drivers/net/phy/microchip.c
> +++ b/drivers/net/phy/microchip.c
> @@ -344,8 +344,8 @@ static int lan88xx_config_aneg(struct phy_device *phydev)
>
> static struct phy_driver microchip_phy_driver[] = {
> {
> - .phy_id = 0x0007c130,
> - .phy_id_mask = 0xfffffff0,
> + .phy_id = 0x0007c132,
> + .phy_id_mask = 0xfffffff2,
That is a very odd mask. Is that really correct?
Please also look at the patch subject line, it is not correct.
Andrew
next prev parent reply other threads:[~2022-04-27 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 11:51 [PATCH net-next 0/2] net: phy: add LAN8742 phy support Yuiko Oshino
2022-04-27 11:51 ` [REVIEW REQUEST3 PATCH net-next 1/2] net: phy: microchip: update LAN88xx phy ID and phy ID mask Yuiko Oshino
2022-04-27 15:30 ` Andrew Lunn [this message]
2022-04-27 11:51 ` [PATCH net-next 2/2] net: phy: smsc: add LAN8742 phy support Yuiko Oshino
2022-04-27 12:06 ` [PATCH net-next 0/2] net: phy: " Woojung.Huh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmlhiQpjUMh+awJ2@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ravi.hegde@microchip.com \
--cc=woojung.huh@microchip.com \
--cc=yuiko.oshino@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).