From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642F8C433F5 for ; Thu, 28 Apr 2022 06:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242811AbiD1GMM (ORCPT ); Thu, 28 Apr 2022 02:12:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233488AbiD1GML (ORCPT ); Thu, 28 Apr 2022 02:12:11 -0400 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8349A972EE for ; Wed, 27 Apr 2022 23:08:58 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 204683200786; Thu, 28 Apr 2022 02:08:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 28 Apr 2022 02:08:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651126134; x= 1651212534; bh=FmGRwSTmiNe+uoRsRcb6/868ljxQoMtp3S38L8mF6dE=; b=m qs9hq0aRCpPJjBgirI+2xsUnvfEGk/gVnKw+IYR+8ZhD0ug5SzWgbqytNYVJiKv5 Vafd6SftEipZpezHXFVfPNhCoFY6EFkH8RhOdW7c1/yKR8OAAhiibPuKPnK2rb2O 5gxAExpJq0z2EjDFS057Xp5yvYOcF2/55KiGAjvtF8bi9OdsJ7eMymxTBWz2zf0a 7ehxIKN+IjlUJUUnibl3EB/fGwFDfEP8+d9FyGwZfbFUnz71zu3ZFe7eD1WYHM8h RRBqDoHZ1pHREAV33JaBbSHBvmttKNbXFcxUplBxlDJ0DaxEGBDSOpQiu6sPg8Pl 9ifMOlTCl6unqbWvboOgA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 02:08:53 -0400 (EDT) Date: Thu, 28 Apr 2022 09:08:49 +0300 From: Ido Schimmel To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , netdev , Eric Dumazet , Ido Schimmel Subject: Re: [PATCH net-next] net: make sure net_rx_action() calls skb_defer_free_flush() Message-ID: References: <20220427204147.1310161-1-eric.dumazet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427204147.1310161-1-eric.dumazet@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 27, 2022 at 01:41:47PM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > I missed a stray return; in net_rx_action(), which very well > is taken whenever trigger_rx_softirq() has been called on > a cpu that is no longer receiving network packets, > or receiving too few of them. > > Fixes: 68822bdf76f1 ("net: generalize skb freeing deferral to per-cpu lists") > Signed-off-by: Eric Dumazet > Reported-by: Ido Schimmel Tested-by: Ido Schimmel Thanks!