From: Simon Horman <simon.horman@corigine.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Yinjun Zhang <yinjun.zhang@corigine.com>
Subject: Re: [PATCH net-next] nfp: flower: utilize the tuple iifidx in offloading ct flows
Date: Fri, 29 Apr 2022 09:02:51 +0200 [thread overview]
Message-ID: <YmuNm7e7RoTIwuov@corigine.com> (raw)
In-Reply-To: <20220428154646.7b9d85cf@kernel.org>
On Thu, Apr 28, 2022 at 03:46:46PM -0700, Jakub Kicinski wrote:
> On Thu, 28 Apr 2022 12:58:56 +0200 Simon Horman wrote:
> > +static inline struct net_device *get_netdev_from_rule(struct flow_rule *rule)
>
> No static inlines in C sources, please, there is only one caller
> so compiler will DDRT.
Sorry about that, we'll fix that in v2.
prev parent reply other threads:[~2022-04-29 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 10:58 [PATCH net-next] nfp: flower: utilize the tuple iifidx in offloading ct flows Simon Horman
2022-04-28 22:46 ` Jakub Kicinski
2022-04-29 7:02 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmuNm7e7RoTIwuov@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).