From: Andrew Lunn <andrew@lunn.ch>
To: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: netdev@vger.kernel.org, Andy Duan <fugang.duan@nxp.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Fabio Estevam <festevam@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Chris Healy <cphealy@gmail.com>
Subject: Re: FEC MDIO read timeout on linkup
Date: Mon, 2 May 2022 20:24:53 +0200 [thread overview]
Message-ID: <YnAh9Q1lwz6Wu9R8@lunn.ch> (raw)
In-Reply-To: <20220502170527.GA137942@francesco-nb.int.toradex.com>
> writing to this register could trigger a FEC_ENET_MII interrupt actually
> creating a race condition with fec_enet_mdio_read() that is called on
> link change also.
Another point to consider:
static int fec_enet_mdio_wait(struct fec_enet_private *fep)
{
uint ievent;
int ret;
ret = readl_poll_timeout_atomic(fep->hwp + FEC_IEVENT, ievent,
ievent & FEC_ENET_MII, 2, 30000);
if (!ret)
writel(FEC_ENET_MII, fep->hwp + FEC_IEVENT);
return ret;
}
An unexpected interrupt will make this exit too early, and the read
will get invalid data. An unexpected interrupt would not cause a
timeout here, which is what you are reporting.
Andrew
next prev parent reply other threads:[~2022-05-02 18:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 15:26 FEC MDIO read timeout on linkup Francesco Dolcini
2022-04-22 15:55 ` Fabio Estevam
2022-04-22 16:04 ` Francesco Dolcini
2022-04-29 15:15 ` Francesco Dolcini
2022-05-02 17:05 ` Francesco Dolcini
2022-05-02 18:21 ` Andrew Lunn
2022-05-02 18:25 ` Francesco Dolcini
2022-05-02 18:24 ` Andrew Lunn [this message]
2022-05-02 18:34 ` Francesco Dolcini
2022-05-03 16:13 ` Francesco Dolcini
2022-05-03 22:17 ` Andrew Lunn
2022-05-05 8:29 ` Francesco Dolcini
2022-05-05 17:41 ` Andrew Lunn
2022-05-05 17:54 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnAh9Q1lwz6Wu9R8@lunn.ch \
--to=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=fugang.duan@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiangqing.zhang@nxp.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox