From: Milan Landaverde <milan@mdaverde.com>
To: Larysa Zaremba <larysa.zaremba@intel.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Alexander Lobakin <alexandr.lobakin@intel.com>
Subject: Re: [PATCH] bpftool: Use sysfs vmlinux when dumping BTF by ID
Date: Thu, 5 May 2022 21:32:17 -0400 [thread overview]
Message-ID: <YnR6oWaoUkEGW1iV@pop-os.localdomain> (raw)
In-Reply-To: <20220428110839.111042-1-larysa.zaremba@intel.com>
Hello! Just ran into this. I think we also need to pass in errno
here to strerror instead of err:
On Thu, Apr 28, 2022 at 01:08:40PM +0200, Larysa Zaremba wrote:
> if (err) {
> p_err("get btf by id (%u): %s", btf_id, strerror(err));
> goto done;
>
Currently, the error output without a base btf reads:
$ bpftool btf dump id 816
Error: get btf by id (816): Unknown error -22
When it should (or at least intends to) read:
$ bpftool btf dump id 816
Error: get btf by id (816): Invalid argument
I was going to send this patch but if a v2 is going to be sent, figured
I mention it. Thanks!
prev parent reply other threads:[~2022-05-06 1:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 11:08 [PATCH] bpftool: Use sysfs vmlinux when dumping BTF by ID Larysa Zaremba
2022-04-29 4:58 ` Andrii Nakryiko
2022-05-05 13:56 ` Larysa Zaremba
2022-05-06 1:32 ` Milan Landaverde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnR6oWaoUkEGW1iV@pop-os.localdomain \
--to=milan@mdaverde.com \
--cc=alexandr.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox