From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Yuiko Oshino <yuiko.oshino@microchip.com>,
woojung.huh@microchip.com, davem@davemloft.net,
netdev@vger.kernel.org, ravi.hegde@microchip.com,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support.
Date: Sat, 7 May 2022 15:48:42 +0200 [thread overview]
Message-ID: <YnZ4uqB688uAeamL@lunn.ch> (raw)
In-Reply-To: <20220506154513.48f16e24@kernel.org>
On Fri, May 06, 2022 at 03:45:13PM -0700, Jakub Kicinski wrote:
> On Thu, 5 May 2022 21:29:13 +0200 Andrew Lunn wrote:
> > On Thu, May 05, 2022 at 11:12:52AM -0700, Yuiko Oshino wrote:
> > > The current phy IDs on the available hardware.
> > > LAN8742 0x0007C130, 0x0007C131
> > >
> > > Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> The comments which I think were requested in the review of v2 and
> appeared in v3 are now gone, again. Is that okay?
Ah, i had not noticed. Thanks for pointing it out.
Those comments are important, since these mask are odd, somebody is
either going to ask about them, or try to 'fix' them. Some robot will
fall over them, etc.
Andrew
next prev parent reply other threads:[~2022-05-07 13:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 18:12 [PATCH v4 net-next 0/2] net: phy: add LAN8742 phy support Yuiko Oshino
2022-05-05 18:12 ` [PATCH v4 net-next 1/2] net: phy: microchip: update LAN88xx phy ID and phy ID mask Yuiko Oshino
2022-05-05 18:12 ` [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support Yuiko Oshino
2022-05-05 19:29 ` Andrew Lunn
2022-05-06 22:45 ` Jakub Kicinski
2022-05-07 13:48 ` Andrew Lunn [this message]
2022-05-09 13:47 ` Yuiko.Oshino
2022-05-09 13:50 ` Andrew Lunn
2022-05-09 14:24 ` Yuiko.Oshino
2022-05-09 16:35 ` Jakub Kicinski
2022-05-09 11:45 ` Yuiko.Oshino
2022-05-09 13:40 ` [PATCH v4 net-next 0/2] net: phy: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnZ4uqB688uAeamL@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ravi.hegde@microchip.com \
--cc=woojung.huh@microchip.com \
--cc=yuiko.oshino@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).